Changeset 34985 in webkit for trunk/JavaScriptCore

Timestamp:

Jul 3, 2008, 12:06:52 PM (17 years ago)

Author:

[email protected]

Message:

2008-07-03 Geoffrey Garen <​[email protected]>

Reviewed by Sam Weinig.

Removed checking for the array get/put fast case from the array code.
Callers who want the fast case should call getIndex and/or setIndex
instead. (get_by_val and put_by_val already do this.)

SunSpider reports no change overall, but a 1.4% speedup on fannkuch and
a 3.6% speedup on nsieve.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• kjs/JSArray.cpp (modified) (3 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-07-03  Geoffrey Garen  <[email protected]>
+
+        Reviewed by Sam Weinig.
+        
+        Removed checking for the array get/put fast case from the array code.
+        Callers who want the fast case should call getIndex and/or setIndex
+        instead. (get_by_val and put_by_val already do this.)
+        
+        SunSpider reports no change overall, but a 1.4% speedup on fannkuch and
+        a 3.6% speedup on nsieve.
+
 2008-07-03  Dan Bernstein  <[email protected]>
 

trunk/JavaScriptCore/kjs/JSArray.cpp

@@ -127 +127 @@
 }
 
-NEVER_INLINE bool JSArray::getOwnPropertySlotSlowCase(ExecState* exec, unsigned i, PropertySlot& slot)
+bool JSArray::getOwnPropertySlot(ExecState* exec, unsigned i, PropertySlot& slot)
 {
     ArrayStorage* storage = m_storage;
@@ -171 +171 @@
 }
 
-bool JSArray::getOwnPropertySlot(ExecState* exec, unsigned i, PropertySlot& slot)
-{
-    if (i < m_fastAccessCutoff) {
-        slot.setValueSlot(&m_storage->m_vector[i]);
-        return true;
-    }
-
-    return getOwnPropertySlotSlowCase(exec, i, slot);
-}
-
 // ECMA 15.4.5.1
 void JSArray::put(ExecState* exec, const Identifier& propertyName, JSValue* value)
@@ -207 +197 @@
 {
     checkConsistency();
-
-    if (i < m_fastAccessCutoff) {
-        m_storage->m_vector[i] = value;
-        checkConsistency();
-        return;
-    }
 
     unsigned length = m_length;