Changeset 35726 in webkit for trunk/JavaScriptCore

Timestamp:

Aug 13, 2008, 1:00:51 PM (17 years ago)

Author:

[email protected]

Message:

2008-08-13 Alp Toker <​[email protected]>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=20349
WTF::initializeThreading() fails if threading is already initialized

Fix threading initialization logic to support cases where
g_thread_init() has already been called elsewhere.

Resolves database-related crashers reported in several applications.

• wtf/ThreadingGtk.cpp: (WTF::initializeThreading):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• wtf/ThreadingGtk.cpp (modified) (2 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-08-13  Alp Toker  <[email protected]>
+
+        Reviewed by Eric Seidel.
+
+        https://bugs.webkit.org/show_bug.cgi?id=20349
+        WTF::initializeThreading() fails if threading is already initialized
+
+        Fix threading initialization logic to support cases where
+        g_thread_init() has already been called elsewhere.
+
+        Resolves database-related crashers reported in several applications.
+
+        * wtf/ThreadingGtk.cpp:
+        (WTF::initializeThreading):
+
 2008-08-13  Brad Hughes <[email protected]>
 

trunk/JavaScriptCore/wtf/ThreadingGtk.cpp

@@ -50 +50 @@
 void initializeThreading()
 {
-    if (!g_thread_supported()) {
+    if (!g_thread_supported())
         g_thread_init(NULL);
-        ASSERT(!atomicallyInitializedStaticMutex);
+    ASSERT(g_thread_supported());
+
+    if (!atomicallyInitializedStaticMutex) {
         atomicallyInitializedStaticMutex = new Mutex;
         threadMapMutex();
@@ -58 +60 @@
         mainThreadIdentifier = currentThread();
     }
-    ASSERT(g_thread_supported());
 }