Changeset 35750 in webkit for trunk/JavaScriptCore

Timestamp:

Aug 13, 2008, 8:43:57 PM (17 years ago)

Author:

[email protected]

Message:

2007-08-13 Geoffrey Garen <​[email protected]>

Reviewed by Oliver Hunt.

Nixed a PIC branch from JSObject::getOwnPropertySlot, by forcing
fillGetterProperty, which references a global function pointer,
out-of-line.

.2% SunSpider speedup, 4.3% access-nbody speedup, 8.7% speedup on a
custom property access benchmark for objects with one property.

• kjs/JSObject.cpp: (KJS::JSObject::fillGetterPropertySlot):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• kjs/JSObject.cpp (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-08-13  Geoffrey Garen  <[email protected]>
+
+        Reviewed by Oliver Hunt.
+        
+        Nixed a PIC branch from JSObject::getOwnPropertySlot, by forcing
+        fillGetterProperty, which references a global function pointer,
+        out-of-line.
+        
+        .2% SunSpider speedup, 4.3% access-nbody speedup, 8.7% speedup on a
+        custom property access benchmark for objects with one property.
+
+        * kjs/JSObject.cpp:
+        (KJS::JSObject::fillGetterPropertySlot):
+
 2008-08-13  Alp Toker  <[email protected]>
 

trunk/JavaScriptCore/kjs/JSObject.cpp

@@ -466 +466 @@
 }
 
-void JSObject::fillGetterPropertySlot(PropertySlot& slot, JSValue** location)
+NEVER_INLINE void JSObject::fillGetterPropertySlot(PropertySlot& slot, JSValue** location)
 {
     if (JSObject* getterFunction = static_cast<GetterSetter*>(*location)->getter())