Ignore:
Timestamp:
Aug 15, 2008, 12:43:48 AM (17 years ago)
Author:
[email protected]
Message:

Reviewed by Geoff Garen.

JSStringRef is created context-free, but can get linked to one via an identifier table,
breaking an implicit API contract.

Made JSStringRef point to OpaqueJSString, which is a new string object separate from UString.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

    r35691 r35775  
    275275                BCF605140E203EF800B9A64D /* ArgList.h in Headers */ = {isa = PBXBuildFile; fileRef = BCF605120E203EF800B9A64D /* ArgList.h */; settings = {ATTRIBUTES = (Private, ); }; };
    276276                C0A272630E50A06300E96E15 /* NotFound.h in Headers */ = {isa = PBXBuildFile; fileRef = C0A2723F0E509F1E00E96E15 /* NotFound.h */; settings = {ATTRIBUTES = (Private, ); }; };
     277                E124A8F70E555775003091F1 /* OpaqueJSString.h in Headers */ = {isa = PBXBuildFile; fileRef = E124A8F50E555775003091F1 /* OpaqueJSString.h */; };
     278                E124A8F80E555775003091F1 /* OpaqueJSString.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E124A8F60E555775003091F1 /* OpaqueJSString.cpp */; };
    277279                E178636D0D9BEEC300D74E75 /* InitializeThreading.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E178636C0D9BEEC300D74E75 /* InitializeThreading.cpp */; };
    278280                E18E3A590DF9278C00D90B34 /* JSGlobalData.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E18E3A570DF9278C00D90B34 /* JSGlobalData.cpp */; };
     
    704706                D21202290AD4310C00ED79B6 /* DateMath.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = DateMath.h; sourceTree = "<group>"; };
    705707                E11D51750B2E798D0056C188 /* StringExtras.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = StringExtras.h; sourceTree = "<group>"; };
     708                E124A8F50E555775003091F1 /* OpaqueJSString.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = OpaqueJSString.h; sourceTree = "<group>"; };
     709                E124A8F60E555775003091F1 /* OpaqueJSString.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = OpaqueJSString.cpp; sourceTree = "<group>"; };
    706710                E178633F0D9BEC0000D74E75 /* InitializeThreading.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = InitializeThreading.h; sourceTree = "<group>"; };
    707711                E178636C0D9BEEC300D74E75 /* InitializeThreading.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = InitializeThreading.cpp; sourceTree = "<group>"; };
     
    907911                                14BD5A2B0A3E91F600BAF59C /* JSValueRef.cpp */,
    908912                                1482B6EA0A4300B300517CFC /* JSValueRef.h */,
     913                                E124A8F60E555775003091F1 /* OpaqueJSString.cpp */,
     914                                E124A8F50E555775003091F1 /* OpaqueJSString.h */,
    909915                                5DE3D0F40DD8DDFB00468714 /* WebKitAvailability.h */,
    910916                        );
     
    15141520                                8613F45B0E3A433E00C948FD /* SamplingTool.h in Headers */,
    15151521                                C0A272630E50A06300E96E15 /* NotFound.h in Headers */,
     1522                                E124A8F70E555775003091F1 /* OpaqueJSString.h in Headers */,
    15161523                        );
    15171524                        runOnlyForDeploymentPostprocessing = 0;
     
    16191626                        projectDirPath = "";
    16201627                        projectRoot = "";
    1621                         projectRoots = (
    1622                                 "",
    1623                         );
    16241628                        targets = (
    16251629                                932F5BE30822A1C700736975 /* All */,
     
    18211825                                905B02AE0E28640F006DF882 /* RefCountedLeakCounter.cpp in Sources */,
    18221826                                8613F45A0E3A433E00C948FD /* SamplingTool.cpp in Sources */,
     1827                                E124A8F80E555775003091F1 /* OpaqueJSString.cpp in Sources */,
    18231828                        );
    18241829                        runOnlyForDeploymentPostprocessing = 0;
Note: See TracChangeset for help on using the changeset viewer.