Changeset 36032 in webkit for trunk/JavaScriptCore/JavaScriptCore.xcodeproj

Timestamp:

Sep 2, 2008, 7:31:45 PM (17 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2008-09-02 Geoffrey Garen <​[email protected]>

Reviewed by Sam Weinig.

Implemented the rest of Darin's review comments for the 09-01 inline
caching patch.

SunSpider says 0.5% faster, but that seems like noise.

• JavaScriptCore.xcodeproj/project.pbxproj: Put PutPropertySlot into its own file, and added BatchedTransitionOptimizer.

• VM/CodeBlock.cpp: (KJS::CodeBlock::~CodeBlock): Use array indexing instead of a pointer iterator.

• VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator): Used BatchedTransitionOptimizer to make batched put and remove for declared variables fast, without forever pessimizing the global object. Removed the old getDirect/removeDirect hack that tried to do the same in a more limited way.

• VM/CodeGenerator.h: Moved IdentifierRepHash to the KJS namespace since it doesn't specialize anything in WTF.

• VM/Machine.cpp: (KJS::Machine::Machine): Nixed the DummyConstruct tag because it was confusingly named.

(KJS::Machine::execute): Used BatchedTransitionOptimizer, as above. Fixed
up some comments.

(KJS::cachePrototypeChain): Cast to JSObject*, since it's more specific.

(KJS::Machine::tryCachePutByID): Use isNull() instead of comparing to
jsNull(), since isNull() leaves more options open for the future.
(KJS::Machine::tryCacheGetByID): ditto
(KJS::Machine::privateExecute): ditto

• VM/SamplingTool.cpp: (KJS::SamplingTool::dump): Use C++-style cast, to match our style guidelines.

• kjs/BatchedTransitionOptimizer.h: Added. New class that allows host code to add a batch of properties to an object in an efficient way.

• kjs/JSActivation.cpp: Use isNull(), as above.

• kjs/JSArray.cpp: Get rid of DummyConstruct tag, as above.
• kjs/JSArray.h:

• kjs/JSGlobalData.cpp: Nixed two unused StructureIDs.
• kjs/JSGlobalData.h:

• kjs/JSImmediate.cpp: Use isNull(), as above.

• kjs/JSObject.cpp: (KJS::JSObject::mark): Moved mark tracing code elsewhere, to make this function more readable.

(KJS::JSObject::put): Use isNull(), as above.

(KJS::JSObject::createInheritorID): Return a raw pointer, since the
object is owned by a data member, not necessarily the caller.

• kjs/JSObject.h:

• kjs/JSString.cpp: Use isNull(), as above.

• kjs/PropertyMap.h: Updated to use PropertySlot::invalidOffset.

• kjs/PropertySlot.h: Changed KJS_INVALID_OFFSET to WTF::notFound because C macros are so 80's.

• kjs/PutPropertySlot.h: Added. Split out of PropertySlot.h. Also renamed PutPropertySlot::SlotType to PutPropertySlot::Type, and slotBase to base, since "slot" was redundant.

• kjs/StructureID.cpp: Added a new transition *away* from dictionary status, to support BatchedTransitionOptimizer.

(KJS::StructureIDChain::StructureIDChain): No need to store m_size as
a data member, so keep it in a local, which might be faster.

• kjs/StructureID.h:

• kjs/SymbolTable.h: Moved IdentifierRepHash to KJS namespace, as above.
• kjs/ustring.h:

JavaScriptGlue:

2008-09-02 Geoffrey Garen <​[email protected]>

Reviewed by Sam Weinig.

Implemented the rest of Darin's review comments for the 09-01 inline
caching patch.

• ForwardingHeaders/kjs/PutPropertySlot.h: Added.

File:

• trunk/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj (modified) (4 diffs)

trunk/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

@@ -55 +55 @@
                 1440FCE40A51E46B0005F061 /* JSClassRef.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1440FCE20A51E46B0005F061 /* JSClassRef.cpp */; };
                 146AAB380B66A94400E55F16 /* JSStringRefCF.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 146AAB370B66A94400E55F16 /* JSStringRefCF.cpp */; };
+                147B83AC0E6DB8C9004775A4 /* BatchedTransitionOptimizer.h in Headers */ = {isa = PBXBuildFile; fileRef = 147B83AA0E6DB8C9004775A4 /* BatchedTransitionOptimizer.h */; };
+                147B84630E6DE6B1004775A4 /* PutPropertySlot.h in Headers */ = {isa = PBXBuildFile; fileRef = 147B84620E6DE6B1004775A4 /* PutPropertySlot.h */; settings = {ATTRIBUTES = (Private, ); }; };
                 1482B74E0A43032800517CFC /* JSStringRef.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1482B74C0A43032800517CFC /* JSStringRef.cpp */; };
                 1482B7E40A43076000517CFC /* JSObjectRef.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1482B7E20A43076000517CFC /* JSObjectRef.cpp */; };
@@ -459 +461 @@
                 146AAB370B66A94400E55F16 /* JSStringRefCF.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = JSStringRefCF.cpp; sourceTree = "<group>"; };
                 14760863099C633800437128 /* JSImmediate.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSImmediate.cpp; sourceTree = "<group>"; };
+                147B83AA0E6DB8C9004775A4 /* BatchedTransitionOptimizer.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = BatchedTransitionOptimizer.h; sourceTree = "<group>"; };
+                147B84620E6DE6B1004775A4 /* PutPropertySlot.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PutPropertySlot.h; sourceTree = "<group>"; };
                 1480DB9B0DDC227F003CFDF2 /* DebuggerCallFrame.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = DebuggerCallFrame.h; path = kjs/DebuggerCallFrame.h; sourceTree = "<group>"; };
                 1482B6EA0A4300B300517CFC /* JSValueRef.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSValueRef.h; sourceTree = "<group>"; };
@@ -1269 +1273 @@
                                 F692A8850255597D01FF60F7 /* ustring.cpp */,
                                 F692A8860255597D01FF60F7 /* ustring.h */,
+                                147B83AA0E6DB8C9004775A4 /* BatchedTransitionOptimizer.h */,
+                                147B84620E6DE6B1004775A4 /* PutPropertySlot.h */,
                         );
                         path = kjs;
@@ -1546 +1552 @@
                                 933040040E6A749400786E6A /* SmallStrings.h in Headers */,
                                 BCDE3AB80E6C82F5001453A7 /* StructureID.h in Headers */,
+                                147B83AC0E6DB8C9004775A4 /* BatchedTransitionOptimizer.h in Headers */,
+                                147B84630E6DE6B1004775A4 /* PutPropertySlot.h in Headers */,
                         );
                         runOnlyForDeploymentPostprocessing = 0;