Changeset 36286 in webkit for trunk/JavaScriptCore/kjs

Timestamp:

Sep 9, 2008, 12:58:53 AM (17 years ago)

Author:

[email protected]

Message:

2008-09-09 Maciej Stachowiak <​[email protected]>

Reviewed by Sam Weinig.

• allow polymorphic inline cache to handle Math object functions and possibly other similar things

1.012x speedup on SunSpider.

• kjs/MathObject.cpp: (JSC::MathObject::getOwnPropertySlot):
• kjs/lookup.cpp: (JSC::setUpStaticFunctionSlot):
• kjs/lookup.h: (JSC::getStaticPropertySlot):

Location:

trunk/JavaScriptCore/kjs

Files:

• MathObject.cpp (modified) (1 diff)
• lookup.cpp (modified) (1 diff)
• lookup.h (modified) (1 diff)

trunk/JavaScriptCore/kjs/MathObject.cpp

@@ -107 +107 @@
 
     ASSERT(entry->attributes & Function);
-    slot.setStaticEntry(this, entry, staticFunctionGetter);
+    setUpStaticFunctionSlot(exec, entry, this, propertyName, slot);
     return true;
 }

trunk/JavaScriptCore/kjs/lookup.cpp

@@ -73 +73 @@
 {
     ASSERT(entry->attributes & Function);
-    PrototypeFunction* function = new (exec) PrototypeFunction(exec, entry->length, propertyName, entry->functionValue);
-    thisObj->putDirect(propertyName, function, entry->attributes);
+    JSValue** location = thisObj->getDirectLocation(propertyName);
+ 
+    if (!location) {
+        PrototypeFunction* function = new (exec) PrototypeFunction(exec, entry->length, propertyName, entry->functionValue);
+        thisObj->putDirect(propertyName, function, entry->attributes);
+        location = thisObj->getDirectLocation(propertyName);
+    }
     
-    JSValue** location = thisObj->getDirectLocation(propertyName);
     slot.setValueSlot(thisObj, location, thisObj->offsetForLocation(location));
 }

trunk/JavaScriptCore/kjs/lookup.h

@@ -146 +146 @@
 
         if (entry->attributes & Function)
-            slot.setStaticEntry(thisObj, entry, staticFunctionGetter);
+            setUpStaticFunctionSlot(exec, entry, thisObj, propertyName, slot);
         else
             slot.setStaticEntry(thisObj, entry, staticValueGetter<ThisImp>);