Changeset 36413 in webkit for trunk/JavaScriptCore

Timestamp:

Sep 14, 2008, 5:35:40 PM (17 years ago)

Author:

[email protected]

Message:

2008-09-14 Gavin Barraclough <​[email protected]>

Reviewed by Sam Weinig.

Remove unnecessary virtual function call from cti_op_call_JSFunction -
~5% on richards, ~2.5% on v8-tests, ~0.5% on sunspider.

• VM/Machine.cpp: (JSC::Machine::cti_op_call_JSFunction):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• VM/Machine.cpp (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-09-14  Gavin Barraclough  <[email protected]>
+
+        Reviewed by Sam Weinig.
+
+        Remove unnecessary virtual function call from cti_op_call_JSFunction -
+        ~5% on richards, ~2.5% on v8-tests, ~0.5% on sunspider.
+
+        * VM/Machine.cpp:
+        (JSC::Machine::cti_op_call_JSFunction):
+
 2008-09-14  Cameron Zwarich  <[email protected]>
 

trunk/JavaScriptCore/VM/Machine.cpp

@@ -4233 +4233 @@
     int argCount = ARG_int4;
 
+    // In the JIT code before entering this function we wil have checked the vptr,
+    // and know this is an object of type JSFunction.
+#ifndef NDEBUG
     CallData callData;
-#ifndef NDEBUG
-    CallType callType =
 #endif
-        funcVal->getCallData(callData);
-
-    ASSERT(callType == CallTypeJS);
+    ASSERT(funcVal->getCallData(callData) == CallTypeJS);
 
     if (*ARG_profilerReference)
         (*ARG_profilerReference)->willExecute(exec, static_cast<JSObject*>(funcVal));
 
-    ScopeChainNode* callDataScopeChain = callData.js.scopeChain;
-    FunctionBodyNode* functionBodyNode = callData.js.functionBody;
+    ScopeChainNode* callDataScopeChain = static_cast<JSFunction*>(funcVal)->m_scopeChain.node();
+    FunctionBodyNode* functionBodyNode = static_cast<JSFunction*>(funcVal)->m_body.get();
+
     CodeBlock* newCodeBlock = &functionBodyNode->byteCode(callDataScopeChain);