Changeset 36418 in webkit for trunk/JavaScriptCore/masm

Timestamp:

Sep 14, 2008, 7:18:13 PM (17 years ago)

Author:

[email protected]

Message:

2008-09-14 Maciej Stachowiak <​[email protected]>

Reviewed by Cameron Zwarich.

• split the "prototype" lookup for hasInstance into opcode stream so it can be cached

~5% speedup on v8 earley-boyer test

• API/JSCallbackObject.h: Add a parameter for the pre-looked-up prototype.
• API/JSCallbackObjectFunctions.h: (JSC::::hasInstance): Ditto.
• API/JSValueRef.cpp: (JSValueIsInstanceOfConstructor): Look up and pass in prototype.
• JavaScriptCore.exp:
• VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): Pass along prototype.
• VM/CodeBlock.cpp: (JSC::CodeBlock::dump): Print third arg.
• VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitInstanceOf): Implement this, now that there is a third argument.
• VM/CodeGenerator.h:
• VM/Machine.cpp: (JSC::Machine::privateExecute): Pass along the prototype. (JSC::Machine::cti_op_instanceof): ditto
• kjs/JSObject.cpp: (JSC::JSObject::hasInstance): Expect to get a pre-looked-up prototype.
• kjs/JSObject.h:
• kjs/nodes.cpp: (JSC::InstanceOfNode::emitCode): Emit a get_by_id of the prototype property and pass that register to instanceof.
• kjs/nodes.h:

File:

• trunk/JavaScriptCore/masm/X86Assembler.h (modified) (5 diffs)

trunk/JavaScriptCore/masm/X86Assembler.h

@@ -210 +210 @@
         OP2_JNE_rel32   = 0x85,
         OP2_JBE_rel32   = 0x86,
+        OP2_JA_rel32    = 0x87,
         OP2_JL_rel32    = 0x8C,
         OP2_JGE_rel32   = 0x8D,
@@ -370 +371 @@
         emitModRm_opm(GROUP1_OP_CMP, addr);
         m_buffer->putInt(imm);
+    }
+
+    void cmpl_i8m(int imm, int offset, RegisterID base, RegisterID index, int scale)
+    {
+        m_buffer->putByte(OP_GROUP1_EvIb);
+        emitModRm_opmsib(GROUP1_OP_CMP, base, index, scale, offset);
+        m_buffer->putByte(imm);
     }
 
@@ -742 +750 @@
     }
     
+    JmpSrc emitUnlinkedJa()
+    {
+        m_buffer->putByte(OP_2BYTE_ESCAPE);
+        m_buffer->putByte(OP2_JA_rel32);
+        m_buffer->putInt(0);
+        return JmpSrc(m_buffer->getOffset());
+    }
+    
     JmpSrc emitUnlinkedJae()
     {
@@ -786 +802 @@
     }
     
-    void* getRelocatedAddress(void* code, JmpSrc jump)
+    static void* getRelocatedAddress(void* code, JmpSrc jump)
     {
         return reinterpret_cast<void*>((ptrdiff_t)code + jump.m_offset);
     }
     
-    void* getRelocatedAddress(void* code, JmpDst jump)
+    static void* getRelocatedAddress(void* code, JmpDst jump)
     {
         return reinterpret_cast<void*>((ptrdiff_t)code + jump.m_offset);
+    }
+    
+    static int getDifferenceBetweenLabels(JmpDst src, JmpDst dst)
+    {
+        return dst.m_offset - src.m_offset;
+    }
+    
+    static int getDifferenceBetweenLabels(JmpDst src, JmpSrc dst)
+    {
+        return dst.m_offset - src.m_offset;
+    }
+    
+    static void repatchImmediate(intptr_t where, int32_t value)
+    {
+        reinterpret_cast<int32_t*>(where)[-1] = value;
+    }
+    
+    static void repatchDisplacement(intptr_t where, intptr_t value)
+    {
+        reinterpret_cast<intptr_t*>(where)[-1] = value;
+    }
+    
+    static void repatchBranchOffset(intptr_t where, void* destination)
+    {
+        reinterpret_cast<intptr_t*>(where)[-1] = (reinterpret_cast<intptr_t>(destination) - where);
     }
     
@@ -932 +973 @@
     }
 
+    void emitModRm_opmsib(OpcodeID opcode, RegisterID base, RegisterID index, int scale, int offset)
+    {
+        emitModRm_rmsib(static_cast<RegisterID>(opcode), base, index, scale, offset);
+    }
+
     JITCodeBuffer* m_buffer;
 };