Changeset 36425 in webkit for trunk/JavaScriptCore

Timestamp:

Sep 14, 2008, 10:05:17 PM (17 years ago)

Author:

[email protected]

Message:

Reviewed by Eric Seidel.

Add a protected destructor for RefCounted.

It is wrong to call its destructor directly, because (1) this should be taken care of by
deref(), and (2) many classes that use RefCounted have non-virtual destructors.

No change in behavior.

• wtf/RefCounted.h: (WTF::RefCounted::~RefCounted):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• wtf/RefCounted.h (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-09-10  Alexey Proskuryakov  <[email protected]>
+
+        Reviewed by Eric Seidel.
+
+        Add a protected destructor for RefCounted.
+
+        It is wrong to call its destructor directly, because (1) this should be taken care of by
+        deref(), and (2) many classes that use RefCounted have non-virtual destructors.
+
+        No change in behavior.
+
+        * wtf/RefCounted.h: (WTF::RefCounted::~RefCounted):
+
 2008-09-14  Gavin Barraclough  <[email protected]>
 

trunk/JavaScriptCore/wtf/RefCounted.h

@@ -67 +67 @@
     }
 
+protected:
+    ~RefCounted() {}
+
 private:
     int m_refCount;