Changeset 36436 in webkit for trunk/JavaScriptCore

Timestamp:

Sep 15, 2008, 3:20:59 AM (17 years ago)

Author:

[email protected]

Message:

2008-09-15 Maciej Stachowiak <​[email protected]>

Reviewed by Cameron Zwarich.

• fix layout test failure introduced by fix for 20849

(The failing test was fast/js/delete-then-put.html)

• kjs/JSObject.cpp: (JSC::JSObject::removeDirect): Clear enumeration cache in the dictionary case.
• kjs/JSObject.h: (JSC::JSObject::putDirect): Ditto.
• kjs/StructureID.h: (JSC::StructureID::clearEnumerationCache): Inline to handle the clear.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• kjs/JSObject.cpp (modified) (1 diff)
• kjs/JSObject.h (modified) (1 diff)
• kjs/StructureID.h (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-09-15  Maciej Stachowiak  <[email protected]>
+
+        Reviewed by Cameron Zwarich.
+        
+        - fix layout test failure introduced by fix for 20849
+        
+        (The failing test was fast/js/delete-then-put.html)
+
+        * kjs/JSObject.cpp:
+        (JSC::JSObject::removeDirect): Clear enumeration cache
+        in the dictionary case.
+        * kjs/JSObject.h:
+        (JSC::JSObject::putDirect): Ditto.
+        * kjs/StructureID.h:
+        (JSC::StructureID::clearEnumerationCache): Inline to handle the
+        clear.
+
 2008-09-15  Maciej Stachowiak  <[email protected]>
 

trunk/JavaScriptCore/kjs/JSObject.cpp

@@ -494 +494 @@
     if (m_structureID->isDictionary()) {
         m_structureID->propertyMap().remove(propertyName, m_propertyStorage);
+        m_structureID->clearEnumerationCache();
         return;
     }

trunk/JavaScriptCore/kjs/JSObject.h

@@ -389 +389 @@
              allocatePropertyStorage(m_structureID->propertyMap().storageSize(), m_structureID->propertyMap().size());
          m_structureID->propertyMap().put(propertyName, value, attributes, checkReadOnly, this, slot, m_propertyStorage);
+         m_structureID->clearEnumerationCache();
          return;
      }

trunk/JavaScriptCore/kjs/StructureID.h

@@ -113 +113 @@
         static void transitionTo(StructureID* oldStructureID, StructureID* newStructureID, JSObject* slotBase);
 
+        void clearEnumerationCache() { m_cachedPropertyNameArray.clear(); }
+
     private:
         typedef std::pair<RefPtr<UString::Rep>, unsigned> TransitionTableKey;