Changeset 36581 in webkit for trunk/JavaScriptCore

Timestamp:

Sep 17, 2008, 5:36:37 PM (17 years ago)

Author:

[email protected]

Message:

2008-09-17 Gavin Barraclough <​[email protected]>

Reviewed by Oliver Hunt.

JIT generation cti_op_construct_verify.

Quarter to half percent progression on v8-tests.
Roughly not change on SunSpider (possible minor progression).

• VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
• VM/Machine.cpp:
• VM/Machine.h:

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• VM/CTI.cpp (modified) (1 diff)
• VM/Machine.cpp (modified) (1 diff)
• VM/Machine.h (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-09-17  Gavin Barraclough  <[email protected]>
+
+        Reviewed by Oliver Hunt.
+
+        JIT generation cti_op_construct_verify.
+        
+        Quarter to half percent progression on v8-tests.
+        Roughly not change on SunSpider (possible minor progression).
+
+        * VM/CTI.cpp:
+        (JSC::CTI::privateCompileMainPass):
+        * VM/Machine.cpp:
+        * VM/Machine.h:
+
 2008-09-15  Steve Falkenburg  <[email protected]>
 

trunk/JavaScriptCore/VM/CTI.cpp

@@ -899 +899 @@
         }
         case op_construct_verify: {
-            emitPutArgConstant(instruction[i + 1].u.operand, 0);
-            emitPutArgConstant(instruction[i + 2].u.operand, 4);
-            emitCall(i, Machine::cti_op_construct_verify);
+            emitGetArg(instruction[i + 1].u.operand, X86::eax);
+            
+            m_jit.testl_i32r(JSImmediate::TagMask, X86::eax);
+            X86Assembler::JmpSrc isImmediate = m_jit.emitUnlinkedJne();
+            m_jit.movl_mr(OBJECT_OFFSET(JSCell, m_structureID), X86::eax, X86::ecx);
+            m_jit.cmpl_i32m(ObjectType, OBJECT_OFFSET(StructureID, m_type), X86::ecx);
+            X86Assembler::JmpSrc isObject = m_jit.emitUnlinkedJe();
+
+            m_jit.link(isImmediate, m_jit.label());
+            emitGetArg(instruction[i + 2].u.operand, X86::ecx);
+            emitPutResult(instruction[i + 1].u.operand, X86::ecx);
+            m_jit.link(isObject, m_jit.label());
+
             i += 3;
             break;

trunk/JavaScriptCore/VM/Machine.cpp

@@ -4546 +4546 @@
 }
 
-void Machine::cti_op_construct_verify(CTI_ARGS)
-{
-    ExecState* exec = ARG_exec;
-    Register* r = ARG_r;
-    int dst = ARG_int1;
-
-    if (LIKELY(r[dst].jsValue(exec)->isObject()))
-        return;
-    
-    int override = ARG_int2;
-    r[dst] = r[override];
-}
-
 JSValue* Machine::cti_op_construct_NotJSConstruct(CTI_ARGS)
 {

trunk/JavaScriptCore/VM/Machine.h

@@ -169 +169 @@
         static void* SFX_CALL cti_op_construct_JSConstruct(CTI_ARGS);
         static JSValue* SFX_CALL cti_op_construct_NotJSConstruct(CTI_ARGS);
-        static void SFX_CALL cti_op_construct_verify(CTI_ARGS);
         static JSValue* SFX_CALL cti_op_get_by_val(CTI_ARGS);
         static JSValue* SFX_CALL cti_op_resolve_func(CTI_ARGS);