Changeset 36764 in webkit for trunk/JavaScriptCore/masm

Timestamp:

Sep 22, 2008, 6:59:06 AM (17 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2008-09-22 Maciej Stachowiak <​[email protected]>

Reviewed by Dave Hyatt.

Based on initial work by Darin Adler.

• replace masqueradesAsUndefined virtual method with a flag in TypeInfo
• use this to JIT inline code for eq_null and neq_null ​https://bugs.webkit.org/show_bug.cgi?id=20823

0.5% speedup on SunSpider
~4% speedup on Richards benchmark

• VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
• VM/Machine.cpp: (JSC::jsTypeStringForValue): (JSC::jsIsObjectType): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_is_undefined):
• VM/Machine.h:
• kjs/JSCell.h:
• kjs/JSValue.h:
• kjs/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::create): (JSC::StringObjectThatMasqueradesAsUndefined::createStructureID):
• kjs/StructureID.h: (JSC::StructureID::mutableTypeInfo):
• kjs/TypeInfo.h: (JSC::TypeInfo::TypeInfo): (JSC::TypeInfo::masqueradesAsUndefined):
• kjs/operations.cpp: (JSC::equal):
• masm/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::setne_r): (JSC::X86Assembler::setnz_r): (JSC::X86Assembler::testl_i32m):

WebCore:

2008-09-22 Maciej Stachowiak <​[email protected]>

Reviewed by Dave Hyatt.

Based on initial work by Darin Adler.

• replace masqueradesAsUndefined virtual method with a flag in TypeInfo
• use this to JIT inline code for eq_null and neq_null ​https://bugs.webkit.org/show_bug.cgi?id=20823

• WebCore.xcodeproj/project.pbxproj:
• WebCore.vcproj/WebCore.vcproj:
• bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::nameGetter):
• bindings/js/JSHTMLAllCollection.cpp: Added. (WebCore::):
• bindings/js/JSHTMLAllCollection.h: (WebCore::JSHTMLAllCollection::createStructureID): (WebCore::JSHTMLAllCollection::toBoolean):

File:

• trunk/JavaScriptCore/masm/X86Assembler.h (modified) (3 diffs)

trunk/JavaScriptCore/masm/X86Assembler.h

@@ -193 +193 @@
         OP_CDQ                          = 0x99,
         OP_SETE                         = 0x94,
+        OP_SETNE                        = 0x95,
         OP_GROUP2_EvIb                  = 0xC1,
         OP_RET                          = 0xC3,
@@ -401 +402 @@
     }
 
+    void setne_r(RegisterID dst)
+    {
+        m_buffer->putByte(OP_2BYTE_ESCAPE);
+        m_buffer->putByte(OP_SETNE);
+        m_buffer->putByte(MODRM(3, 0, dst));
+    }
+
+    void setnz_r(RegisterID dst)
+    {
+        setne_r(dst);
+    }
+
     void orl_rr(RegisterID src, RegisterID dst)
     {
@@ -453 +466 @@
         emitModRm_opr_Unchecked(GROUP3_OP_TEST, dst);
         m_buffer->putIntUnchecked(imm);
+    }
+
+    void testl_i32m(int imm, RegisterID dst)
+    {
+        m_buffer->putByte(OP_GROUP3_EvIz);
+        emitModRm_opm(GROUP3_OP_TEST, dst);
+        m_buffer->putInt(imm);
+    }
+
+    void testl_i32m(int imm, int offset, RegisterID dst)
+    {
+        m_buffer->putByte(OP_GROUP3_EvIz);
+        emitModRm_opm(GROUP3_OP_TEST, dst, offset);
+        m_buffer->putInt(imm);
     }