Changeset 37240 in webkit for trunk/JavaScriptCore

Timestamp:

Oct 3, 2008, 9:09:37 AM (17 years ago)

Author:

Darin Adler

Message:

2008-10-03 Darin Adler <Darin Adler>

Suggested by Alexey Proskuryakov.

• kjs/JSGlobalData.cpp: (JSC::JSGlobalData::~JSGlobalData): Remove call to heap.destroy() because it's too late to ref the JSGlobalData object once it's already being destroyed. In practice this is not a problem because WebCore's JSGlobalData is never destroyed and JSGlobalContextRelease takes care of calling heap.destroy() in advance.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• kjs/JSGlobalData.cpp (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-10-03  Darin Adler  <[email protected]>
+
+        Suggested by Alexey Proskuryakov.
+
+        * kjs/JSGlobalData.cpp:
+        (JSC::JSGlobalData::~JSGlobalData): Remove call to heap.destroy() because
+        it's too late to ref the JSGlobalData object once it's already being
+        destroyed. In practice this is not a problem because WebCore's JSGlobalData
+        is never destroyed and JSGlobalContextRelease takes care of calling
+        heap.destroy() in advance.
+
 2008-10-02  Oliver Hunt  <[email protected]>
 

trunk/JavaScriptCore/kjs/JSGlobalData.cpp

@@ -95 +95 @@
 JSGlobalData::~JSGlobalData()
 {
-    heap.destroy();
+    // By the time this is destroyed, heap.destroy() must already have been called.
+
     delete machine;
 #ifndef NDEBUG