Changeset 37294 in webkit for trunk/JavaScriptCore

Timestamp:

Oct 4, 2008, 1:32:21 PM (17 years ago)

Author:

[email protected]

Message:

2008-10-04 Cameron Zwarich <​[email protected]>

Reviewed by Darin Adler.

Bug 21369: Add opcode documentation for all undocumented opcodes
<​https://bugs.webkit.org/show_bug.cgi?id=21369>

This patch adds opcode documentation for all undocumented opcodes, and
it also renames op_init_arguments to op_create_arguments.

• VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
• VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
• VM/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator):
• VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_create_arguments):
• VM/Machine.h:
• VM/Opcode.h:

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• VM/CTI.cpp (modified) (1 diff)
• VM/CodeBlock.cpp (modified) (1 diff)
• VM/CodeGenerator.cpp (modified) (1 diff)
• VM/Machine.cpp (modified) (5 diffs)
• VM/Machine.h (modified) (1 diff)
• VM/Opcode.h (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-10-04  Cameron Zwarich  <[email protected]>
+
+        Reviewed by Darin Adler.
+
+        Bug 21369: Add opcode documentation for all undocumented opcodes
+        <https://bugs.webkit.org/show_bug.cgi?id=21369>
+
+        This patch adds opcode documentation for all undocumented opcodes, and
+        it also renames op_init_arguments to op_create_arguments.
+
+        * VM/CTI.cpp:
+        (JSC::CTI::privateCompileMainPass):
+        * VM/CodeBlock.cpp:
+        (JSC::CodeBlock::dump):
+        * VM/CodeGenerator.cpp:
+        (JSC::CodeGenerator::CodeGenerator):
+        * VM/Machine.cpp:
+        (JSC::Machine::privateExecute):
+        (JSC::Machine::cti_op_create_arguments):
+        * VM/Machine.h:
+        * VM/Opcode.h:
+
 2008-10-03  Maciej Stachowiak  <[email protected]>
 

trunk/JavaScriptCore/VM/CTI.cpp

@@ -1989 +1989 @@
             break;
         }
-        case op_init_arguments: {
-            emitCall(i, Machine::cti_op_init_arguments);
+        case op_create_arguments: {
+            emitCall(i, Machine::cti_op_create_arguments);
             i += 1;
             break;

trunk/JavaScriptCore/VM/CodeBlock.cpp

@@ -357 +357 @@
             break;
         }
-        case op_init_arguments: {
-            printf("[%4d] init_arguments\n", location);
+        case op_create_arguments: {
+            printf("[%4d] create_arguments\n", location);
             break;
         }

trunk/JavaScriptCore/VM/CodeGenerator.cpp

@@ -296 +296 @@
     codeBlock->usesArguments = usesArguments;
     if (usesArguments) {
-        emitOpcode(op_init_arguments);
+        emitOpcode(op_create_arguments);
         m_argumentsRegister.setIndex(RegisterFile::OptionalCalleeArguments);
         addVar(propertyNames().arguments, false);

trunk/JavaScriptCore/VM/Machine.cpp

@@ -3343 +3343 @@
            register base to those of the calling function.
         */
-           
+
         int result = (++vPC)->u.operand;
 
@@ -3377 +3377 @@
     }
     BEGIN_OPCODE(op_enter) {
+        /* enter
+
+           Initializes local variables to undefined and fills constant
+           registers with their values. If the code block requires an
+           activation, enter_with_activation should be used instead.
+
+           This opcode should only be used at the beginning of a code
+           block.
+        */
+
         size_t i = 0;
         CodeBlock* codeBlock = this->codeBlock(r);
@@ -3390 +3400 @@
     }
     BEGIN_OPCODE(op_enter_with_activation) {
+        /* enter_with_activation
+
+           Initializes local variables to undefined, fills constant
+           registers with their values, creates an activation object,
+           and places the new activation both in the activation slot
+           in the call frame and at the top of the scope chain. If the
+           code block does not require an activation, enter should be
+           used instead.
+
+           This opcode should only be used at the beginning of a code
+           block.
+        */
+
         size_t i = 0;
         CodeBlock* codeBlock = this->codeBlock(r);
@@ -3415 +3438 @@
         NEXT_OPCODE;
     }
-    BEGIN_OPCODE(op_init_arguments) {
+    BEGIN_OPCODE(op_create_arguments) {
+        /* create_arguments
+
+           Creates the 'arguments' object and places it in both the
+           'arguments' call frame slot and the local 'arguments'
+           register.
+
+           This opcode should only be used at the beginning of a code
+           block.
+        */
+
         JSValue* activation = r[RegisterFile::OptionalCalleeActivation].getJSValue();
         Arguments* arguments;
@@ -4626 +4659 @@
 }
 
-void Machine::cti_op_init_arguments(CTI_ARGS)
+void Machine::cti_op_create_arguments(CTI_ARGS)
 {
     ExecState* exec = ARG_exec;

trunk/JavaScriptCore/VM/Machine.h

@@ -165 +165 @@
         static void* SFX_CALL cti_op_call_JSFunction(CTI_ARGS);
         static JSValue* SFX_CALL cti_op_call_NotJSFunction(CTI_ARGS);
-        static void SFX_CALL cti_op_init_arguments(CTI_ARGS);
+        static void SFX_CALL cti_op_create_arguments(CTI_ARGS);
         static void SFX_CALL cti_op_ret_activation_arguments(CTI_ARGS);
         static void SFX_CALL cti_op_ret_profiler(CTI_ARGS);

trunk/JavaScriptCore/VM/Opcode.h

@@ -43 +43 @@
         macro(op_enter) \
         macro(op_enter_with_activation) \
-        macro(op_init_arguments) \
+        macro(op_create_arguments) \
         macro(op_convert_this) \
         \