Changeset 37570 in webkit for trunk/JavaScriptCore/masm

Timestamp:

Oct 13, 2008, 5:20:49 PM (17 years ago)

Author:

[email protected]

Message:

2008-10-13 Cameron Zwarich <​[email protected]>

Reviewed by Geoff Garen.

Bug 21541: Move RegisterFile growth check to callee
<​https://bugs.webkit.org/show_bug.cgi?id=21541>

Move the RegisterFile growth check to the callee in the common case,
where some of the information is known statically at JIT time. There is
still a check in the caller in the case where the caller provides too
few arguments.

This is a 2.1% speedup on the V8 benchmark, including a 5.1% speedup on
the Richards benchmark, a 4.1% speedup on the DeltaBlue benchmark, and a
1.4% speedup on the Earley-Boyer benchmark. It is also a 0.5% speedup on
SunSpider.

• VM/CTI.cpp: (JSC::CTI::privateCompile):
• VM/Machine.cpp: (JSC::Machine::cti_register_file_check): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_construct_JSConstruct):
• VM/Machine.h:
• VM/RegisterFile.h:
• masm/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::cmpl_mr): (JSC::X86Assembler::emitUnlinkedJg):

File:

• trunk/JavaScriptCore/masm/X86Assembler.h (modified) (4 diffs)

trunk/JavaScriptCore/masm/X86Assembler.h

@@ -192 +192 @@
         OP_XOR_EvGv                     = 0x31,
         OP_CMP_EvGv                     = 0x39,
+        OP_CMP_GvEv                     = 0x3B,
         OP_PUSH_EAX                     = 0x50,
         OP_POP_EAX                      = 0x58,
@@ -241 +242 @@
         OP2_JGE_rel32       = 0x8D,
         OP2_JLE_rel32       = 0x8E,
+        OP2_JG_rel32       = 0x8F,
         OP2_IMUL_GvEv       = 0xAF,
         OP2_MOVZX_GvEb      = 0xB6,
@@ -372 +374 @@
         m_buffer->putByte(OP_CMP_EvGv);
         emitModRm_rm(src, base, offset);
+    }
+
+    void cmpl_mr(int offset, RegisterID base, RegisterID dst)
+    {
+        m_buffer->putByte(OP_CMP_GvEv);
+        emitModRm_rm(dst, base, offset);
     }
 
@@ -946 +954 @@
         return JmpSrc(m_buffer->getOffset());
     }
-    
+
+    JmpSrc emitUnlinkedJg()
+    {
+        m_buffer->putByte(OP_2BYTE_ESCAPE);
+        m_buffer->putByte(OP2_JG_rel32);
+        m_buffer->putInt(0);
+        return JmpSrc(m_buffer->getOffset());
+    }
+
     JmpSrc emitUnlinkedJa()
     {