Changeset 37586 in webkit for trunk/JavaScriptCore

Timestamp:

Oct 14, 2008, 9:22:20 AM (17 years ago)

Author:

[email protected]

Message:

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=20256
Array.push and other standard methods disappear

• kjs/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::~JSGlobalData): Don't use static hash tables even on platforms that don't enable JSC_MULTIPLE_THREADS - these tables reference IdentifierTable, which is always per-GlobalData.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• kjs/JSGlobalData.cpp (modified) (4 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-10-14  Alexey Proskuryakov  <[email protected]>
+
+        Reviewed by Darin Adler.
+
+        https://bugs.webkit.org/show_bug.cgi?id=20256
+        Array.push and other standard methods disappear
+
+        * kjs/JSGlobalData.cpp:
+        (JSC::JSGlobalData::JSGlobalData):
+        (JSC::JSGlobalData::~JSGlobalData):
+        Don't use static hash tables even on platforms that don't enable JSC_MULTIPLE_THREADS -
+        these tables reference IdentifierTable, which is always per-GlobalData.
+
 2008-10-14  Maciej Stachowiak  <[email protected]>
 

trunk/JavaScriptCore/kjs/JSGlobalData.cpp

@@ -62 +62 @@
     : machine(new Machine)
     , exception(0)
-#if ENABLE(JSC_MULTIPLE_THREADS)
     , arrayTable(new HashTable(JSC::arrayTable))
     , dateTable(new HashTable(JSC::dateTable))
@@ -70 +69 @@
     , regExpConstructorTable(new HashTable(JSC::regExpConstructorTable))
     , stringTable(new HashTable(JSC::stringTable))
-#else
-    , arrayTable(&JSC::arrayTable)
-    , dateTable(&JSC::dateTable)
-    , mathTable(&JSC::mathTable)
-    , numberTable(&JSC::numberTable)
-    , regExpTable(&JSC::regExpTable)
-    , regExpConstructorTable(&JSC::regExpConstructorTable)
-    , stringTable(&JSC::stringTable)
-#endif
     , nullProtoStructureID(JSObject::createStructureID(jsNull()))
     , activationStructureID(JSActivation::createStructureID(jsNull()))
@@ -109 +99 @@
 #endif
 
-#if ENABLE(JSC_MULTIPLE_THREADS)
     arrayTable->deleteTable();
     dateTable->deleteTable();
@@ -124 +113 @@
     delete regExpConstructorTable;
     delete stringTable;
-#endif
 
     delete parser;