Changeset 37629 in webkit for trunk/JavaScriptCore

Timestamp:

Oct 15, 2008, 10:31:41 PM (17 years ago)

Author:

[email protected]

Message:

2008-10-15 Sam Weinig <​[email protected]>

Reviewed by Goeffrey Garen.

Add function to dump statistics for StructureIDs.

• kjs/StructureID.cpp: (JSC::StructureID::dumpStatistics): (JSC::StructureID::StructureID): (JSC::StructureID::~StructureID):
• kjs/StructureID.h:

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• kjs/StructureID.cpp (modified) (3 diffs)
• kjs/StructureID.h (modified) (2 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-10-15  Sam Weinig  <[email protected]>
+
+        Reviewed by Goeffrey Garen.
+
+        Add function to dump statistics for StructureIDs.
+
+        * kjs/StructureID.cpp:
+        (JSC::StructureID::dumpStatistics):
+        (JSC::StructureID::StructureID):
+        (JSC::StructureID::~StructureID):
+        * kjs/StructureID.h:
+
 2008-10-15  Cameron Zwarich  <[email protected]>
 

trunk/JavaScriptCore/kjs/StructureID.cpp

@@ -38 +38 @@
 namespace JSC {
 
-#ifndef NDEBUG    
+#ifndef NDEBUG
 static WTF::RefCountedLeakCounter structureIDCounter("StructureID");
 
 static bool shouldIgnoreLeaks;
 static HashSet<StructureID*> ignoreSet;
+#endif
+
+#if DUMP_STRUCTURE_ID_STATISTICS
+static HashSet<StructureID*> liveStructureIDSet;
+
+void StructureID::dumpStatistics()
+{
+    unsigned numberUsingSingleSlot = 0;
+
+    HashSet<StructureID*>::const_iterator end = liveStructureIDSet.end();
+    for (HashSet<StructureID*>::const_iterator it = liveStructureIDSet.begin(); it != end; ++it) {
+        StructureID* structureID = *it;
+        if (structureID->m_usingSingleTransitionSlot)
+            ++numberUsingSingleSlot;
+    }
+
+    printf("Number of live StructureIDs: %d\n", liveStructureIDSet.size());
+    printf("Number of StructureIDs using the single item optimization for transition map: %d\n", numberUsingSingleSlot);
+}
 #endif
 
@@ -69 +88 @@
         structureIDCounter.increment();
 #endif
+
+#if DUMP_STRUCTURE_ID_STATISTICS
+    liveStructureIDSet.add(this);
+#endif
 }
 
@@ -98 +121 @@
     else
         structureIDCounter.decrement();
+#endif
+
+#if DUMP_STRUCTURE_ID_STATISTICS
+    liveStructureIDSet.remove(this);
 #endif
 }

trunk/JavaScriptCore/kjs/StructureID.h

@@ -38 +38 @@
 #include <wtf/PassRefPtr.h>
 #include <wtf/RefCounted.h>
+
+#define DUMP_STRUCTURE_ID_STATISTICS 0
 
 namespace JSC {
@@ -85 +87 @@
         static void startIgnoringLeaks();
         static void stopIgnoringLeaks();
+
+#if DUMP_STRUCTURE_ID_STATISTICS
+        static void dumpStatistics();
+#endif
 
         static PassRefPtr<StructureID> changePrototypeTransition(StructureID*, JSValue* prototype);