Changeset 37632 in webkit for trunk/JavaScriptCore

Timestamp:

Oct 16, 2008, 4:11:24 AM (17 years ago)

Author:

[email protected]

Message:

2008-10-16 Maciej Stachowiak <​[email protected]>

Reviewed by Cameron Zwarich.

• fix for: REGRESSION: over 100 StructureIDs leak loading about:blank (result of fix for bug 21633)

Apparent slight progression (< 0.5%) on v8 benchmarks and SunSpider.

• kjs/StructureID.cpp: (JSC::StructureID::~StructureID): Don't deref this object's parent's pointer to itself from the destructor; that doesn't even make sense. (JSC::StructureID::addPropertyTransition): Don't refer the single transition; the rule is that parent StructureIDs are ref'd but child ones are not. Refing the child creates a cycle.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• kjs/StructureID.cpp (modified) (4 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-10-16  Maciej Stachowiak  <[email protected]>
+
+        Reviewed by Cameron Zwarich.
+        
+        - fix for: REGRESSION: over 100 StructureIDs leak loading about:blank (result of fix for bug 21633)
+        
+        Apparent slight progression (< 0.5%) on v8 benchmarks and SunSpider.
+
+        * kjs/StructureID.cpp:
+        (JSC::StructureID::~StructureID): Don't deref this object's parent's pointer to
+        itself from the destructor; that doesn't even make sense.
+        (JSC::StructureID::addPropertyTransition): Don't refer the single transition;
+        the rule is that parent StructureIDs are ref'd but child ones are not. Refing
+        the child creates a cycle.
+
 2008-10-15  Alexey Proskuryakov  <[email protected]>
 

trunk/JavaScriptCore/kjs/StructureID.cpp

@@ -109 +109 @@
     if (m_previous) {
         if (m_previous->m_usingSingleTransitionSlot) {
-            m_previous->m_transitions.singleTransition->deref();
             m_previous->m_transitions.singleTransition = 0;
         } else {
@@ -120 +119 @@
         m_cachedPropertyNameArrayData->setCachedStructureID(0);
 
-    if (m_usingSingleTransitionSlot) {
-        if (m_transitions.singleTransition)
-            m_transitions.singleTransition->deref();
-    } else
+    if (!m_usingSingleTransitionSlot)
         delete m_transitions.table;
 
@@ -266 +262 @@
         if (!structureID->m_transitions.singleTransition) {
             structureID->m_transitions.singleTransition = transition.get();
-            transition->ref();
             return transition.release();
         }
@@ -275 +270 @@
         structureID->m_transitions.table = transitionTable;
         transitionTable->add(make_pair(existingTransition->m_nameInPrevious, existingTransition->m_attributesInPrevious), existingTransition);
-        existingTransition->deref();
     }
     structureID->m_transitions.table->add(make_pair(propertyName.ustring().rep(), attributes), transition.get());