Changeset 37750 in webkit for trunk/JavaScriptCore

Timestamp:

Oct 20, 2008, 5:10:01 PM (17 years ago)

Author:

[email protected]

Message:

2008-10-20 Cameron Zwarich <​[email protected]>

Rubber-stamped by Sam Weinig.

• VM/Machine.cpp: (JSC::Machine::privateExecute):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• VM/Machine.cpp (modified) (3 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-10-20  Cameron Zwarich  <[email protected]>
+
+        Rubber-stamped by Sam Weinig.
+
+        * VM/Machine.cpp:
+        (JSC::Machine::privateExecute):
+
 2008-10-16  Sam Weinig  <[email protected]>
 

trunk/JavaScriptCore/VM/Machine.cpp

@@ -3350 +3350 @@
     }
     BEGIN_OPCODE(op_tear_off_activation) {
+        /* tear_off_activation activation(r)
+
+           Copy all locals and parameters to new memory allocated on
+           the heap, and make the passed activation use this memory
+           in the future when looking up entries in the symbol table.
+           If there is an 'arguments' object, then it will also use
+           this memory for storing the named parameters, but not any
+           extra arguments.
+
+           This opcode should only be used immediately before op_ret.
+        */
+
         int src = (++vPC)->u.operand;
         ASSERT(callFrame->codeBlock()->needsFullScopeChain);
@@ -3359 +3371 @@
     }
     BEGIN_OPCODE(op_tear_off_arguments) {
+        /* tear_off_arguments
+
+           Copy all arguments to new memory allocated on the heap,
+           and make the 'arguments' object use this memory in the
+           future when looking up named parameters, but not any
+           extra arguments. If an activation object exists for the
+           current function context, then the tear_off_activation
+           opcode should be used instead.
+
+           This opcode should only be used immediately before op_ret.
+        */
+
         ASSERT(callFrame->codeBlock()->usesArguments && !callFrame->codeBlock()->needsFullScopeChain);
 
@@ -3448 +3472 @@
     }
     BEGIN_OPCODE(op_convert_this) {
+        /* convert_this this(r)
+
+           Takes the value in the 'this' register, converts it to a
+           value that is suitable for use as the 'this' value, and
+           stores it in the 'this' register. This opcode is emitted
+           to avoid doing the conversion in the caller unnecessarily.
+
+           This opcode should only be used at the beginning of a code
+           block.
+        */
+
         int thisRegister = (++vPC)->u.operand;
         JSValuePtr thisVal = callFrame[thisRegister].getJSValue();