Changeset 38012 in webkit for trunk/JavaScriptCore

Timestamp:

Oct 30, 2008, 3:16:26 PM (17 years ago)

Author:

[email protected]

Message:

2008-10-30 Cameron Zwarich <​[email protected]>

Reviewed by Oliver Hunt.

Bug 21987: CTI::putDoubleResultToJSNumberCellOrJSImmediate() hardcodes its result register
<​https://bugs.webkit.org/show_bug.cgi?id=21987>

CTI::putDoubleResultToJSNumberCellOrJSImmediate() hardcodes its result
register as ecx, but it should be tempReg1, which is ecx at all of its
callsites.

• VM/CTI.cpp: (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• VM/CTI.cpp (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-10-30  Cameron Zwarich  <[email protected]>
+
+        Reviewed by Oliver Hunt.
+
+        Bug 21987: CTI::putDoubleResultToJSNumberCellOrJSImmediate() hardcodes its result register
+        <https://bugs.webkit.org/show_bug.cgi?id=21987>
+
+        CTI::putDoubleResultToJSNumberCellOrJSImmediate() hardcodes its result
+        register as ecx, but it should be tempReg1, which is ecx at all of its
+        callsites.
+
+        * VM/CTI.cpp:
+        (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate):
+
 2008-10-30  Cameron Zwarich  <[email protected]>
 

trunk/JavaScriptCore/VM/CTI.cpp

@@ -796 +796 @@
     // Yes it really really really is representable as a JSImmediate.
     emitFastArithIntToImmNoCheck(tempReg1);
-    emitPutResult(dst, X86::ecx);
+    emitPutResult(dst, tempReg1);
 }