Changeset 38133 in webkit for trunk/JavaScriptCore/VM

Timestamp:

Nov 5, 2008, 11:51:35 AM (17 years ago)

Author:

[email protected]

Message:

2008-11-05 Geoffrey Garen <​[email protected]>

Suggested by Darin Adler.

Removed two copy constructors that the compiler can generate for us
automatically.

• VM/LabelID.h: (JSC::LabelID::setLocation): (JSC::LabelID::offsetFrom): (JSC::LabelID::ref): (JSC::LabelID::refCount):
• kjs/LabelScope.h:

File:

• trunk/JavaScriptCore/VM/LabelID.h (modified) (4 diffs)

trunk/JavaScriptCore/VM/LabelID.h

@@ -47 +47 @@
         }
 
-        // It doesn't really make sense to copy a LabelID, but we need this copy
-        // constructor to support moving LabelIDs in a Vector.
-
-        LabelID(const LabelID& other)
-            : m_refCount(other.m_refCount)
-            , m_location(other.m_location)
-            , m_codeBlock(other.m_codeBlock)
-            , m_unresolvedJumps(other.m_unresolvedJumps)
-        {
-        #ifndef NDEBUG
-            const_cast<LabelID&>(other).m_codeBlock = 0;
-        #endif
-        }
-
         void setLocation(unsigned location)
         {
-            ASSERT(m_codeBlock);
             m_location = location;
 
@@ -77 +62 @@
         int offsetFrom(int location) const
         {
-            ASSERT(m_codeBlock);
             if (m_location == invalidLocation) {
                 m_unresolvedJumps.append(location);
@@ -85 +69 @@
         }
 
-        void ref()
-        {
-            ++m_refCount;
-        }
-
+        void ref() { ++m_refCount; }
         void deref()
         {
@@ -95 +75 @@
             ASSERT(m_refCount >= 0);
         }
-
-        int refCount() const
-        {
-            return m_refCount;
-        }
+        int refCount() const { return m_refCount; }
 
         bool isForwardLabel() const { return m_location == invalidLocation; }