Changeset 38265 in webkit for trunk/JavaScriptCore

Timestamp:

Nov 10, 2008, 10:17:15 AM (17 years ago)

Author:

[email protected]

Message:

2008-11-10 Cameron Zwarich <​[email protected]>

Reviewed by Darin Adler.

Bug 22152: Remove asObject() call from JSCallbackObject::getOwnPropertySlot()
<​https://bugs.webkit.org/show_bug.cgi?id=22152>

With the recent change to adopt asType() style cast functions with
assertions instead of static_casts in many places, the assertion for
the asObject() call in JSCallbackObject::getOwnPropertySlot() has been
failing when using any nontrivial client of the JavaScriptCore API.
The cast isn't even necessary to call slot.setCustom(), so it should
be removed.

• API/JSCallbackObjectFunctions.h: (JSC::JSCallbackObject::getOwnPropertySlot):

Location:

trunk/JavaScriptCore

Files:

• API/JSCallbackObjectFunctions.h (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/JavaScriptCore/API/JSCallbackObjectFunctions.h

@@ -131 +131 @@
                 // FIXME: This violates the PropertySlot design a little bit.
                 // We should either use this optimization everywhere, or nowhere.
-                slot.setCustom(asObject(toJS(value)), cachedValueGetter);
+                slot.setCustom(toJS(value), cachedValueGetter);
                 return true;
             }

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-11-10  Cameron Zwarich  <[email protected]>
+
+        Reviewed by Darin Adler.
+
+        Bug 22152: Remove asObject() call from JSCallbackObject::getOwnPropertySlot()
+        <https://bugs.webkit.org/show_bug.cgi?id=22152>
+
+        With the recent change to adopt asType() style cast functions with
+        assertions instead of static_casts in many places, the assertion for
+        the asObject() call in JSCallbackObject::getOwnPropertySlot() has been
+        failing when using any nontrivial client of the JavaScriptCore API.
+        The cast isn't even necessary to call slot.setCustom(), so it should
+        be removed.
+
+        * API/JSCallbackObjectFunctions.h:
+        (JSC::JSCallbackObject::getOwnPropertySlot):
+
 2008-11-10  Alexey Proskuryakov  <[email protected]>