Changeset 38420 in webkit for trunk/JavaScriptCore/parser

Timestamp:

Nov 15, 2008, 12:22:22 AM (17 years ago)

Author:

[email protected]

Message:

2008-11-15 Maciej Stachowiak <​[email protected]>

Reviewed by Sam Weinig.

• Remove SymbolTable from FunctionBodyNode and move it to CodeBlock

It's not needed for functions that have never been executed, so no
need to waste the memory. Saves ~4M on membuster after 30 pages.

• VM/CodeBlock.h:
• VM/Machine.cpp: (JSC::Machine::retrieveArguments):
• parser/Nodes.cpp: (JSC::EvalNode::generateCode): (JSC::FunctionBodyNode::generateCode):
• parser/Nodes.h:
• runtime/JSActivation.h: (JSC::JSActivation::JSActivationData::JSActivationData):

Location:

trunk/JavaScriptCore/parser

Files:

• Nodes.cpp (modified) (2 diffs)
• Nodes.h (modified) (2 diffs)

trunk/JavaScriptCore/parser/Nodes.cpp

@@ -2432 +2432 @@
     JSGlobalObject* globalObject = scopeChain.globalObject();
 
-    SymbolTable symbolTable;
     m_code.set(new EvalCodeBlock(this, globalObject, source().provider()));
 
-    CodeGenerator generator(this, globalObject->debugger(), scopeChain, &symbolTable, m_code.get());
+    CodeGenerator generator(this, globalObject->debugger(), scopeChain, &m_code->symbolTable, m_code.get());
     generator.generate();
 }
@@ -2501 +2500 @@
     m_code.set(new CodeBlock(this, FunctionCode, source().provider(), source().startOffset()));
 
-    CodeGenerator generator(this, globalObject->debugger(), scopeChain, &m_symbolTable, m_code.get());
+    CodeGenerator generator(this, globalObject->debugger(), scopeChain, &m_code->symbolTable, m_code.get());
     generator.generate();
 }

trunk/JavaScriptCore/parser/Nodes.h

@@ -2153 +2153 @@
         virtual RegisterID* emitCode(CodeGenerator&, RegisterID* = 0) JSC_FAST_CALL;
         
-        SymbolTable& symbolTable() { return m_symbolTable; } // FIXME: Remove this
-        
         CodeBlock& byteCode(ScopeChainNode* scopeChain) JSC_FAST_CALL
         {
@@ -2202 +2200 @@
         Identifier* m_parameters;
         size_t m_parameterCount;
-        SymbolTable m_symbolTable;
         OwnPtr<CodeBlock> m_code;
         unsigned m_refCount;