Changeset 38444 in webkit for trunk/JavaScriptCore/runtime

Timestamp:

Nov 16, 2008, 2:05:23 AM (17 years ago)

Author:

[email protected]

Message:

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=22290
Remove cross-heap GC and MessagePort multi-threading support

It is broken (and may not be implementable at all), and no longer needed, as we
don't use MessagePorts for communication with workers any more.

JavaScriptCore:

• JavaScriptCore.exp:
• runtime/Collector.cpp: (JSC::Heap::collect):
• runtime/JSGlobalObject.cpp:
• runtime/JSGlobalObject.h: Remove hooks for cross-heap GC.

WebCore:

• bindings/js/JSDOMBinding.cpp:
• bindings/js/JSDOMBinding.h:
• bindings/js/JSDOMWindowBase.cpp:
• bindings/js/JSDOMWindowBase.h: Removed cross-heap GC implementation.

• dom/MessagePort.cpp: (WebCore::MessagePort::hasPendingActivity):
• dom/MessagePort.h: Made objects RefCounted instead of ThreadSafeShared, added FIXME comments for code that is unnecessarily complicated for single threaded case.

Location:

trunk/JavaScriptCore/runtime

Files:

• Collector.cpp (modified) (1 diff)
• JSGlobalObject.cpp (modified) (1 diff)
• JSGlobalObject.h (modified) (1 diff)

trunk/JavaScriptCore/runtime/Collector.cpp

@@ -985 +985 @@
     m_globalData->smallStrings.mark();
 
-    JSGlobalObject* globalObject = m_globalData->head;
-    if (globalObject) {
-        do {
-            globalObject->markCrossHeapDependentObjects();
-            globalObject = globalObject->next();
-        } while (globalObject != m_globalData->head);
-    }
-
     JAVASCRIPTCORE_GC_MARKED();
 

trunk/JavaScriptCore/runtime/JSGlobalObject.cpp

@@ -408 +408 @@
 }
 
-void JSGlobalObject::markCrossHeapDependentObjects()
-{
-    // Overridden by subclasses.
-}
-
 JSGlobalObject* JSGlobalObject::toGlobalObject(ExecState*) const
 {

trunk/JavaScriptCore/runtime/JSGlobalObject.h

@@ -159 +159 @@
 
         virtual void mark();
-        virtual void markCrossHeapDependentObjects();
 
         virtual bool getOwnPropertySlot(ExecState*, const Identifier&, PropertySlot&);