Changeset 38669 in webkit for trunk/JavaScriptCore/assembler

Timestamp:

Nov 21, 2008, 11:31:34 AM (17 years ago)

Author:

[email protected]

Message:

2008-11-21 Geoffrey Garen <​[email protected]>

Reviewed by Sam Weinig.

A little more RegExp refactoring.

Moved all assembly from WREC.cpp into WRECGenerator helper functions.
This should help with portability and readability.

Removed ASSERTs after calls to executableCopy(), and changed
executableCopy() to ASSERT instead.

• assembler/X86Assembler.h: (JSC::X86Assembler::executableCopy):
• jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::privateCompilePatchGetArrayLength):
• wrec/WREC.cpp: (JSC::WREC::compileRegExp):
• wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter): (JSC::WREC::Generator::generateReturnSuccess): (JSC::WREC::Generator::generateSaveIndex): (JSC::WREC::Generator::generateIncrementIndex): (JSC::WREC::Generator::generateLoopIfNotEndOfInput): (JSC::WREC::Generator::generateReturnFailure):
• wrec/WRECGenerator.h:
• wrec/WRECParser.h: (JSC::WREC::Parser::ignoreCase): (JSC::WREC::Parser::generator):

File:

• trunk/JavaScriptCore/assembler/X86Assembler.h (modified) (1 diff)

trunk/JavaScriptCore/assembler/X86Assembler.h

@@ -1007 +1007 @@
     }
     
-    void* executableCopy() 
-    {
-        return m_buffer->executableCopy();
+    void* executableCopy()
+    {
+        void* copy = m_buffer->executableCopy();
+        ASSERT(copy);
+        return copy;
     }