Changeset 38917 in webkit for trunk/JavaScriptCore/assembler

Timestamp:

Dec 2, 2008, 1:52:24 PM (16 years ago)

Author:

[email protected]

Message:

2008-12-02 Geoffrey Garen <​[email protected]>

Reviewed by Geoffrey Garen. (Patch by Cameron Zwarich <​[email protected]>.)

Fixed ​https://bugs.webkit.org/show_bug.cgi?id=22482
REGRESSION (r37991): Occasionally see "Scene rendered incorrectly"
message when running the V8 Raytrace benchmark

Rolled out r37991. It didn't properly save xmm0, which is caller-save,
before calling helper functions.

SunSpider and v8 benchmarks show little change -- possibly a .2%
SunSpider regression, possibly a .2% v8 benchmark speedup.

• assembler/X86Assembler.h: (JSC::X86Assembler::):
• bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
• bytecode/Instruction.h: (JSC::Instruction::):
• bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitUnaryOp):
• bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::emitToJSNumber): (JSC::BytecodeGenerator::emitTypeOf): (JSC::BytecodeGenerator::emitGetPropertyNames):
• interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
• interpreter/Interpreter.h:
• jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
• jit/JIT.h:
• parser/Nodes.cpp: (JSC::UnaryOpNode::emitBytecode): (JSC::BinaryOpNode::emitBytecode): (JSC::EqualNode::emitBytecode):
• parser/ResultType.h: (JSC::ResultType::isReusable): (JSC::ResultType::mightBeNumber):
• runtime/JSNumberCell.h:

File:

• trunk/JavaScriptCore/assembler/X86Assembler.h (modified) (4 diffs)

trunk/JavaScriptCore/assembler/X86Assembler.h

@@ -124 +124 @@
         OP2_CVTTSD2SI_GdWsd = 0x2C,
         OP2_UCOMISD_VsdWsd  = 0x2E,
-        OP2_XORPD_VsdWsd    = 0x57,
         OP2_ADDSD_VsdWsd    = 0x58,
         OP2_MULSD_VsdWsd    = 0x59,
@@ -160 +159 @@
 
         GROUP3_OP_TEST = 0,
-        GROUP3_OP_NEG  = 3,
         GROUP3_OP_IDIV = 7,
 
@@ -591 +589 @@
     }
 
-    void negl_r(RegisterID dst)
-    {
-        m_buffer->putByte(OP_GROUP3_Ev);
-        modRm_opr(GROUP3_OP_NEG, dst);
-    }
-
     void cdq()
     {
@@ -770 +762 @@
         modRm_rm((RegisterID)dst, base, offset);
     }
-
-#if !PLATFORM(X86_64)
-    void xorpd_mr(void* addr, XMMRegisterID dst)
-    {
-        m_buffer->putByte(PRE_SSE_66);
-        m_buffer->putByte(OP_2BYTE_ESCAPE);
-        m_buffer->putByte(OP2_XORPD_VsdWsd);
-        modRm_rm((RegisterID)dst, addr);
-    }
-#endif
 
     void movsd_rm(XMMRegisterID src, int offset, RegisterID base)