Changeset 38971 in webkit for trunk/JavaScriptCore

Timestamp:

Dec 3, 2008, 2:54:36 PM (16 years ago)

Author:

[email protected]

Message:

2008-12-03 Geoffrey Garen <​[email protected]>

Reviewed by Oliver Hunt, with help from Gavin Barraclough.

orl_i32r was actually coded as an 8bit OR. So, I renamed orl_i32r to
orl_i8r, changed all orl_i32r clients to use orl_i8r, and then added
a new orl_i32r that actually does a 32bit OR.

(32bit OR is currently unused, but a patch I'm working on uses it.)

• assembler/MacroAssembler.h: (JSC::MacroAssembler::or32): Updated to choose between 8bit and 32bit OR.

• assembler/X86Assembler.h: (JSC::X86Assembler::orl_i8r): The old orl_i32r. (JSC::X86Assembler::orl_i32r): The new orl_i32r.

• jit/JIT.cpp: (JSC::JIT::emitFastArithPotentiallyReTagImmediate): (JSC::JIT::emitTagAsBoolImmediate): Use orl_i8r, since we're ORing 8bit values.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• assembler/MacroAssembler.h (modified) (1 diff)
• assembler/X86Assembler.h (modified) (1 diff)
• jit/JIT.cpp (modified) (2 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-12-03  Geoffrey Garen  <[email protected]>
+
+        Reviewed by Oliver Hunt, with help from Gavin Barraclough.
+        
+        orl_i32r was actually coded as an 8bit OR. So, I renamed orl_i32r to
+        orl_i8r, changed all orl_i32r clients to use orl_i8r, and then added
+        a new orl_i32r that actually does a 32bit OR.
+        
+        (32bit OR is currently unused, but a patch I'm working on uses it.)
+
+        * assembler/MacroAssembler.h:
+        (JSC::MacroAssembler::or32): Updated to choose between 8bit and 32bit OR.
+
+        * assembler/X86Assembler.h:
+        (JSC::X86Assembler::orl_i8r): The old orl_i32r.
+        (JSC::X86Assembler::orl_i32r): The new orl_i32r.
+        
+        * jit/JIT.cpp:
+        (JSC::JIT::emitFastArithPotentiallyReTagImmediate):
+        (JSC::JIT::emitTagAsBoolImmediate): Use orl_i8r, since we're ORing 8bit
+        values.
+
 2008-12-03  Dean Jackson  <[email protected]>
 

trunk/JavaScriptCore/assembler/MacroAssembler.h

@@ -285 +285 @@
     void or32(Imm32 imm, RegisterID dest)
     {
-        m_assembler.orl_i32r(imm.m_value, dest);
+        if (CAN_SIGN_EXTEND_8_32(imm.m_value))
+            m_assembler.orl_i8r(imm.m_value, dest);
+        else
+            m_assembler.orl_i32r(imm.m_value, dest);
     }
 

trunk/JavaScriptCore/assembler/X86Assembler.h

@@ -450 +450 @@
     }
 
-    void orl_i32r(int imm, RegisterID dst)
+    void orl_i8r(int imm, RegisterID dst)
     {
         m_buffer->putByte(OP_GROUP1_EvIb);
         modRm_opr(GROUP1_OP_OR, dst);
         m_buffer->putByte(imm);
+    }
+
+    void orl_i32r(int imm, RegisterID dst)
+    {
+        m_buffer->putByte(OP_GROUP1_EvIz);
+        modRm_opr(GROUP1_OP_OR, dst);
+        m_buffer->putInt(imm);
     }
 

trunk/JavaScriptCore/jit/JIT.cpp

@@ -562 +562 @@
 ALWAYS_INLINE void JIT::emitFastArithPotentiallyReTagImmediate(RegisterID reg)
 {
-    __ orl_i32r(JSImmediate::TagBitTypeInteger, reg);
+    __ orl_i8r(JSImmediate::TagBitTypeInteger, reg);
 }
 
@@ -586 +586 @@
 {
     __ shl_i8r(JSImmediate::ExtendedPayloadShift, reg);
-    __ orl_i32r(JSImmediate::FullTagTypeBool, reg);
+    __ orl_i8r(JSImmediate::FullTagTypeBool, reg);
 }