Changeset 39055 in webkit for trunk/JavaScriptCore

Timestamp:

Dec 5, 2008, 4:52:05 PM (16 years ago)

Author:

[email protected]

Message:

2008-12-05 Gavin Barraclough <​[email protected]>

Reviewed by Geoff Garen.

Remove redundant calls to JIT::emitSlowScriptCheck.
This is checked in the hot path, so is not needed on the slow path - and the code
was being planted before the start of the slow case, so was completely unreachable!

• jit/JIT.cpp: (JSC::JIT::privateCompileSlowCases):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• jit/JIT.cpp (modified) (3 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-12-05  Gavin Barraclough  <[email protected]>
+
+        Reviewed by Geoff Garen.
+
+        Remove redundant calls to JIT::emitSlowScriptCheck.
+        This is checked in the hot path, so is not needed on the slow path - and the code
+        was being planted before the start of the slow case, so was completely unreachable!
+
+        * jit/JIT.cpp:
+        (JSC::JIT::privateCompileSlowCases):
+
 2008-12-05  Gavin Barraclough  <[email protected]>
 

trunk/JavaScriptCore/jit/JIT.cpp

@@ -1606 +1606 @@
         }
         case op_loop_if_less: {
-            emitSlowScriptCheck(i);
-
             unsigned target = instruction[i + 3].u.operand;
             JSValue* src2imm = getConstantImmediateNumericArg(instruction[i + 2].u.operand);
@@ -1640 +1638 @@
         }
         case op_loop_if_lesseq: {
-            emitSlowScriptCheck(i);
-
             unsigned target = instruction[i + 3].u.operand;
             JSValue* src2imm = getConstantImmediateNumericArg(instruction[i + 2].u.operand);
@@ -1702 +1698 @@
         }
         case op_loop_if_true: {
-            emitSlowScriptCheck(i);
-
             __ link(iter->from, __ label());
             emitPutCTIArg(X86::eax, 0);