Changeset 39083 in webkit for trunk/JavaScriptCore/assembler

Timestamp:

Dec 7, 2008, 3:55:04 PM (16 years ago)

Author:

[email protected]

Message:

<rdar://problem/6309878> Need more granular control over allocation of executable memory (21783)
<​https://bugs.webkit.org/show_bug.cgi?id=21783>

Reviewed by Cameron Zwarich and Sam Weinig

Add a new allocator for use by the JIT that provides executable pages, so
we can get rid of the current hack that makes the entire heap executable.

1-2% progression on SunSpider-v8, 1% on SunSpider. Reduces memory usage as well!

Location:

trunk/JavaScriptCore/assembler

Files:

• AssemblerBuffer.h (modified) (2 diffs)
• MacroAssembler.h (modified) (1 diff)
• X86Assembler.h (modified) (2 diffs)

trunk/JavaScriptCore/assembler/AssemblerBuffer.h

@@ -32 +32 @@
 
 #include <string.h>
+#include <jit/ExecutableAllocator.h>
 #include <wtf/Assertions.h>
 #include <wtf/FastMalloc.h>
@@ -110 +111 @@
         }
 
-        int size()
+        int size() const
         {
             return m_size;
         }
 
-        void* executableCopy()
+        void* executableCopy(ExecutablePool* allocator)
         {
             if (!m_size)
                 return 0;
 
-            void* result = WTF::fastMallocExecutable(m_size);
+            void* result = allocator->alloc(m_size);
 
             if (!result)

trunk/JavaScriptCore/assembler/MacroAssembler.h

@@ -54 +54 @@
     }
     
-    void* copyCode()
-    {
-        return m_assembler.executableCopy();
+    size_t size() { return m_assembler.size(); }
+    void* copyCode(ExecutablePool* allocator)
+    {
+        return m_assembler.executableCopy(allocator);
     }
 

trunk/JavaScriptCore/assembler/X86Assembler.h

@@ -211 +211 @@
     }
 
+    size_t size() const { return m_buffer.size(); }
+    
     void int3()
     {
@@ -1114 +1116 @@
     }
     
-    void* executableCopy()
-    {
-        void* copy = m_buffer.executableCopy();
+    void* executableCopy(ExecutablePool* allocator)
+    {
+        void* copy = m_buffer.executableCopy(allocator);
         ASSERT(copy);
         return copy;