Changeset 39625 in webkit for trunk/JavaScriptCore/JavaScriptCore.xcodeproj

Timestamp:

Jan 5, 2009, 3:57:09 PM (17 years ago)

Author:

[email protected]

Message:

CanvasPixelArray performance is too slow
<​https://bugs.webkit.org/show_bug.cgi?id=23123>

Reviewed by Gavin Barraclough

JavaScriptCore:
The fix to this is to devirtualise get and put in a manner similar to
JSString and JSArray. To do this I've added a ByteArray implementation
and JSByteArray wrapper to JSC. We can then do vptr comparisons to
devirtualise the calls.

This devirtualisation improves performance by 1.5-2x in my somewhat ad
hoc tests.

WebCore:
Remove the WebCore CanvasPixelArray implementation and replace
CPA usage with JSC::ByteArray. Replace the JSCanvasPixelArray
wrapper with an explicitly instantiated JSByteArray put on the
JSImageData object as an ordinary ReadOnly, DontDelete property.

File:

• trunk/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj (modified) (5 diffs)

trunk/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

@@ -159 +159 @@
                 A766B44F0EE8DCD1009518CA /* ExecutableAllocator.h in Headers */ = {isa = PBXBuildFile; fileRef = A7B48DB50EE74CFC00DCBDB6 /* ExecutableAllocator.h */; settings = {ATTRIBUTES = (Private, ); }; };
                 A782F1A50EEC9FA20036273F /* ExecutableAllocatorPosix.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A782F1A40EEC9FA20036273F /* ExecutableAllocatorPosix.cpp */; };
+                A791EE5B0F11D90C00AE1F68 /* ByteArray.h in Headers */ = {isa = PBXBuildFile; fileRef = A791EE590F11D90C00AE1F68 /* ByteArray.h */; settings = {ATTRIBUTES = (Private, ); }; };
+                A791EE5C0F11D90C00AE1F68 /* ByteArray.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A791EE5A0F11D90C00AE1F68 /* ByteArray.cpp */; };
+                A791EF280F11E07900AE1F68 /* JSByteArray.h in Headers */ = {isa = PBXBuildFile; fileRef = A791EF260F11E07900AE1F68 /* JSByteArray.h */; settings = {ATTRIBUTES = (Private, ); }; };
+                A791EF290F11E07900AE1F68 /* JSByteArray.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A791EF270F11E07900AE1F68 /* JSByteArray.cpp */; };
                 A7B48F490EE8936F00DCBDB6 /* ExecutableAllocator.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A7B48DB60EE74CFC00DCBDB6 /* ExecutableAllocator.cpp */; };
                 BC02E90D0E1839DB000F9297 /* ErrorConstructor.h in Headers */ = {isa = PBXBuildFile; fileRef = BC02E9050E1839DB000F9297 /* ErrorConstructor.h */; };
@@ -646 +650 @@
                 A727FF660DA3053B00E548D7 /* JSPropertyNameIterator.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSPropertyNameIterator.cpp; sourceTree = "<group>"; };
                 A782F1A40EEC9FA20036273F /* ExecutableAllocatorPosix.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ExecutableAllocatorPosix.cpp; sourceTree = "<group>"; };
+                A791EE590F11D90C00AE1F68 /* ByteArray.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ByteArray.h; sourceTree = "<group>"; };
+                A791EE5A0F11D90C00AE1F68 /* ByteArray.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ByteArray.cpp; sourceTree = "<group>"; };
+                A791EF260F11E07900AE1F68 /* JSByteArray.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSByteArray.h; sourceTree = "<group>"; };
+                A791EF270F11E07900AE1F68 /* JSByteArray.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSByteArray.cpp; sourceTree = "<group>"; };
                 A7B48DB50EE74CFC00DCBDB6 /* ExecutableAllocator.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ExecutableAllocator.h; sourceTree = "<group>"; };
                 A7B48DB60EE74CFC00DCBDB6 /* ExecutableAllocator.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ExecutableAllocator.cpp; sourceTree = "<group>"; };
@@ -1338 +1346 @@
                                 F692A8850255597D01FF60F7 /* UString.cpp */,
                                 F692A8860255597D01FF60F7 /* UString.h */,
+                                A791EE590F11D90C00AE1F68 /* ByteArray.h */,
+                                A791EE5A0F11D90C00AE1F68 /* ByteArray.cpp */,
+                                A791EF260F11E07900AE1F68 /* JSByteArray.h */,
+                                A791EF270F11E07900AE1F68 /* JSByteArray.cpp */,
                         );
                         path = runtime;
@@ -1676 +1688 @@
                                 BC18C44E0E16F5CD00B34460 /* pcre_internal.h in Headers */,
                                 BC18C4720E16F5CD00B34460 /* ucpinternal.h in Headers */,
+                                A791EE5B0F11D90C00AE1F68 /* ByteArray.h in Headers */,
+                                A791EF280F11E07900AE1F68 /* JSByteArray.h in Headers */,
                         );
                         runOnlyForDeploymentPostprocessing = 0;
@@ -2024 +2038 @@
                                 93E26BD408B1514100F85226 /* pcre_xclass.cpp in Sources */,
                                 5D6A566B0F05995500266145 /* Threading.cpp in Sources */,
+                                A791EE5C0F11D90C00AE1F68 /* ByteArray.cpp in Sources */,
+                                A791EF290F11E07900AE1F68 /* JSByteArray.cpp in Sources */,
                         );
                         runOnlyForDeploymentPostprocessing = 0;