Changeset 39817 in webkit for trunk/JavaScriptCore/API

Timestamp:

Jan 11, 2009, 11:34:12 PM (16 years ago)

Author:

[email protected]

Message:

2009-01-11 David Levin <​[email protected]>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=23245

Add initializeThreading to key places in JS API to ensure that
UString is properly initialized.

• API/JSContextRef.cpp: (JSContextGroupCreate): (JSGlobalContextCreate):
• API/JSObjectRef.cpp: (JSClassCreate):
• API/JSStringRef.cpp: (JSStringCreateWithCharacters): (JSStringCreateWithUTF8CString):
• API/JSStringRefCF.cpp: (JSStringCreateWithCFString):

Location:

trunk/JavaScriptCore/API

Files:

• JSContextRef.cpp (modified) (2 diffs)
• JSObjectRef.cpp (modified) (2 diffs)
• JSStringRef.cpp (modified) (3 diffs)
• JSStringRefCF.cpp (modified) (3 diffs)

trunk/JavaScriptCore/API/JSContextRef.cpp

@@ -45 +45 @@
 JSContextGroupRef JSContextGroupCreate()
 {
+    initializeThreading();
     return toRef(JSGlobalData::create().releaseRef());
 }
@@ -61 +62 @@
 JSGlobalContextRef JSGlobalContextCreate(JSClassRef globalObjectClass)
 {
+    initializeThreading();
 #if PLATFORM(DARWIN)
     // When running on Tiger or Leopard, or if the application was linked before JSGlobalContextCreate was changed

trunk/JavaScriptCore/API/JSObjectRef.cpp

@@ -33 +33 @@
 #include "FunctionConstructor.h"
 #include "Identifier.h"
+#include "InitializeThreading.h"
 #include "JSArray.h"
 #include "JSCallbackConstructor.h"
@@ -53 +54 @@
 JSClassRef JSClassCreate(const JSClassDefinition* definition)
 {
+    initializeThreading();
     RefPtr<OpaqueJSClass> jsClass = (definition->attributes & kJSClassAttributeNoAutomaticPrototype)
         ? OpaqueJSClass::createNoAutomaticPrototype(definition)

trunk/JavaScriptCore/API/JSStringRef.cpp

@@ -27 +27 @@
 #include "JSStringRef.h"
 
+#include "InitializeThreading.h"
 #include "OpaqueJSString.h"
 #include <wtf/unicode/UTF8.h>
@@ -35 +36 @@
 JSStringRef JSStringCreateWithCharacters(const JSChar* chars, size_t numChars)
 {
+    initializeThreading();
     return OpaqueJSString::create(chars, numChars).releaseRef();
 }
@@ -40 +42 @@
 JSStringRef JSStringCreateWithUTF8CString(const char* string)
 {
+    initializeThreading();
     if (string) {
         size_t length = strlen(string);

trunk/JavaScriptCore/API/JSStringRefCF.cpp

@@ -28 +28 @@
 
 #include "APICast.h"
+#include "InitializeThreading.h"
 #include "JSStringRef.h"
 #include "OpaqueJSString.h"
@@ -36 +37 @@
 JSStringRef JSStringCreateWithCFString(CFStringRef string)
 {
+    JSC::initializeThreading();
     CFIndex length = CFStringGetLength(string);
     if (length) {
@@ -45 +47 @@
         return OpaqueJSString::create(0, 0).releaseRef();
     }
-    }
+}
 
 CFStringRef JSStringCopyCFString(CFAllocatorRef alloc, JSStringRef string)