Changeset 39998 in webkit for trunk/JavaScriptCore/parser

Timestamp:

Jan 16, 2009, 4:39:01 PM (16 years ago)

Author:

[email protected]

Message:

2009-01-16 Gavin Barraclough <​[email protected]>

Reviewed by Oliver Hunt.

Add support to x86-64 JIT for inline double precision arithmetic ops.
+5/6% on x86-64, JIT enabled, sunspider.

• assembler/MacroAssembler.h: (JSC::MacroAssembler::addPtr):
• assembler/X86Assembler.h: (JSC::X86Assembler::movq_rr):
• jit/JIT.h:
• jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_pre_inc): (JSC::JIT::compileBinaryArithOp): (JSC::JIT::compileBinaryArithOpSlowCase): (JSC::JIT::compileFastArith_op_add): (JSC::JIT::compileFastArithSlow_op_add): (JSC::JIT::compileFastArith_op_mul): (JSC::JIT::compileFastArithSlow_op_mul): (JSC::JIT::compileFastArith_op_sub): (JSC::JIT::compileFastArithSlow_op_sub):
• parser/ResultType.h: (JSC::ResultType::isReusable): (JSC::ResultType::isInt32): (JSC::ResultType::definitelyIsNumber): (JSC::ResultType::mightBeNumber): (JSC::ResultType::isNotNumber): (JSC::ResultType::unknownType):

File:

• trunk/JavaScriptCore/parser/ResultType.h (modified) (3 diffs)

trunk/JavaScriptCore/parser/ResultType.h

@@ -42 +42 @@
         static const Type TypeMaybeOther  = 0x40;
 
+        static const Type TypeBits = TypeMaybeNumber | TypeMaybeString | TypeMaybeNull | TypeMaybeBool | TypeMaybeOther;
+
         explicit ResultType(Type type)
             : m_type(type)
@@ -49 +51 @@
         bool isReusable()
         {
-            return (m_type & TypeReusable);
+            return m_type & TypeReusable;
         }
 
         bool isInt32()
         {
-            return (m_type & TypeInt32);
+            return m_type & TypeInt32;
         }
 
         bool definitelyIsNumber()
         {
-            return ((m_type & ~TypeReusable) == TypeMaybeNumber);
-        }
-        
-        bool isNotNumber()
-        {
-            return !(m_type & TypeMaybeNumber);
+            return (m_type & TypeBits) == TypeMaybeNumber;
         }
         
         bool mightBeNumber()
         {
-            return !isNotNumber();
+            return m_type & TypeMaybeNumber;
         }
 
+        bool isNotNumber()
+        {
+            return !mightBeNumber();
+        }
+        
         static ResultType nullType()
         {
@@ -109 +111 @@
         static ResultType unknownType()
         {
-            return ResultType(TypeMaybeNumber | TypeMaybeString | TypeMaybeNull | TypeMaybeBool | TypeMaybeOther);
+            return ResultType(TypeBits);
         }