Changeset 40004 in webkit for trunk/JavaScriptCore/assembler

Timestamp:

Jan 16, 2009, 8:57:56 PM (16 years ago)

Author:

[email protected]

Message:

2009-01-16 Gavin Barraclough <​[email protected]>

Reviewed by Oliver Hunt.

On x86-64 jit, cache JSImmedate::TagMask & JSImmedate::TagTypeNumber in
registers, save reloading them every time they're used.

Draws x86-64 jit performance close to that of i386 jit.

• assembler/MacroAssembler.h: (JSC::MacroAssembler::subPtr): (JSC::MacroAssembler::jnzPtr): (JSC::MacroAssembler::jzPtr):
• jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
• jit/JIT.h:
• jit/JITArithmetic.cpp: (JSC::JIT::compileBinaryArithOpSlowCase):
• jit/JITInlineMethods.h: (JSC::JIT::emitJumpIfJSCell): (JSC::JIT::emitJumpIfNotJSCell): (JSC::JIT::emitJumpIfImmediateNumber): (JSC::JIT::emitJumpIfNotImmediateNumber): (JSC::JIT::emitJumpIfImmediateInteger): (JSC::JIT::emitJumpIfNotImmediateInteger): (JSC::JIT::emitFastArithIntToImmNoCheck):

File:

• trunk/JavaScriptCore/assembler/MacroAssembler.h (modified) (5 diffs)

trunk/JavaScriptCore/assembler/MacroAssembler.h

@@ -700 +700 @@
     }
 
+    void subPtr(RegisterID src, RegisterID dest)
+    {
+#if PLATFORM(X86_64)
+        m_assembler.subq_rr(src, dest);
+#else
+        sub32(src, dest);
+#endif
+    }
+    
     void subPtr(Imm32 imm, RegisterID dest)
     {
@@ -1590 +1599 @@
     }
     
+    Jump jnzPtr(RegisterID reg, RegisterID mask)
+    {
+#if PLATFORM(X86_64)
+        m_assembler.testq_rr(reg, mask);
+        return Jump(m_assembler.jne());
+#else
+        return jnz32(reg, mask);
+#endif
+    }
+
     Jump jnzPtr(RegisterID reg, Imm32 mask = Imm32(-1))
     {
@@ -1621 +1640 @@
     }
 
+    Jump jnz32(RegisterID reg, RegisterID mask)
+    {
+        m_assembler.testl_rr(reg, mask);
+        return Jump(m_assembler.jne());
+    }
+
     Jump jnz32(RegisterID reg, Imm32 mask = Imm32(-1))
     {
@@ -1631 +1656 @@
         testImm32(address, mask);
         return Jump(m_assembler.jne());
+    }
+
+    Jump jzPtr(RegisterID reg, RegisterID mask)
+    {
+#if PLATFORM(X86_64)
+        m_assembler.testq_rr(reg, mask);
+        return Jump(m_assembler.je());
+#else
+        return jz32(reg, mask);
+#endif
     }
 
@@ -1672 +1707 @@
         return jz32(address, mask);
 #endif
+    }
+
+    Jump jz32(RegisterID reg, RegisterID mask)
+    {
+        m_assembler.testl_rr(reg, mask);
+        return Jump(m_assembler.je());
     }