Changeset 40042 in webkit for trunk/JavaScriptCore/runtime

Timestamp:

Jan 19, 2009, 3:33:54 PM (16 years ago)

Author:

Darin Adler

Message:

JavaScriptCore:

2009-01-19 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Bug 23409: REGRESSION: RegExp 'replace()' function improperly processes '$$'
<​https://bugs.webkit.org/show_bug.cgi?id=23409>
<rdar://problem/6505723>

Test: fast/js/string-replace-3.html

• runtime/StringPrototype.cpp: (JSC::substituteBackreferences): Remove code that adds an extra $ -- not sure how this ever worked.

LayoutTests:

2009-01-19 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Bug 23409: REGRESSION: RegExp 'replace()' function improperly processes '$$'
<​https://bugs.webkit.org/show_bug.cgi?id=23409>
<rdar://problem/6505723>

• fast/js/resources/string-replace-3.js:
• fast/js/string-replace-3-expected.txt:

File:

• trunk/JavaScriptCore/runtime/StringPrototype.cpp (modified) (1 diff)

trunk/JavaScriptCore/runtime/StringPrototype.cpp

@@ -147 +147 @@
             substitutedReplacement.append(replacement.data() + offset, i - offset);
             offset = i + 1;
-            substitutedReplacement.append('$');
             continue;
         }