Changeset 41053 in webkit for trunk/JavaScriptCore

Timestamp:

Feb 17, 2009, 8:17:47 PM (16 years ago)

Author:

[email protected]

Message:

2009-02-17 Geoffrey Garen <​[email protected]>

Reviewed by Sam Weinig.

Fixed failure in js1_5/Regress/regress-168347.js, as seen on the Oliver
bot.

Technically, both behaviors are OK, but we might as well keep this test
passing.

• runtime/FunctionPrototype.cpp: (JSC::insertSemicolonIfNeeded): No need to add a trailing semicolon after a trailing '}', since '}' ends a block, indicating the end of a statement.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/FunctionPrototype.cpp (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2009-02-17  Geoffrey Garen  <[email protected]>
+
+        Reviewed by Sam Weinig.
+        
+        Fixed failure in js1_5/Regress/regress-168347.js, as seen on the Oliver
+        bot.
+        
+        Technically, both behaviors are OK, but we might as well keep this test
+        passing.
+
+        * runtime/FunctionPrototype.cpp:
+        (JSC::insertSemicolonIfNeeded): No need to add a trailing semicolon
+        after a trailing '}', since '}' ends a block, indicating the end of a
+        statement.
+
 2009-02-17  Geoffrey Garen  <[email protected]>
 

trunk/JavaScriptCore/runtime/FunctionPrototype.cpp

@@ -74 +74 @@
         UChar ch = functionBody[i];
         if (!Lexer::isWhiteSpace(ch) && !Lexer::isLineTerminator(ch)) {
-            if (ch != ';')
+            if (ch != ';' && ch != '}')
                 functionBody = functionBody.substr(0, i + 1) + ";" + functionBody.substr(i + 1, functionBody.size() - (i + 1));
             return;