Changeset 41474 in webkit for trunk/JavaScriptCore/assembler

Timestamp:

Mar 5, 2009, 11:02:10 PM (16 years ago)

Author:

[email protected]

Message:

2009-03-05 Gavin Barraclough <​[email protected]>

Reviewed by Oliver Hunt.

Writes of constant values to SF registers should be made with direct memory
writes where possible, rather than moving the value via a hardware register.

~3% win on SunSpider tests on x86, ~1.5% win on v8 tests on x86-64.

• assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::storePtr):
• assembler/X86Assembler.h: (JSC::X86Assembler::movq_i32m):
• jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):

Location:

trunk/JavaScriptCore/assembler

Files:

• MacroAssemblerX86_64.h (modified) (1 diff)
• X86Assembler.h (modified) (1 diff)

trunk/JavaScriptCore/assembler/MacroAssemblerX86_64.h

@@ -245 +245 @@
     void storePtr(ImmPtr imm, ImplicitAddress address)
     {
-        move(imm, scratchRegister);
-        storePtr(scratchRegister, address);
+        intptr_t ptr = imm.asIntptr();
+        if (CAN_SIGN_EXTEND_32_64(ptr))
+            m_assembler.movq_i32m(static_cast<int>(ptr), address.offset, address.base);
+        else {
+            move(imm, scratchRegister);
+            storePtr(scratchRegister, address);
+        }
     }
 

trunk/JavaScriptCore/assembler/X86Assembler.h

@@ -928 +928 @@
     }
 
+    void movq_i32m(int imm, int offset, RegisterID base)
+    {
+        m_formatter.oneByteOp64(OP_GROUP11_EvIz, GROUP11_MOV, base, offset);
+        m_formatter.immediate32(imm);
+    }
+
     void movq_i64r(int64_t imm, RegisterID dst)
     {