Changeset 41818 in webkit for trunk/JavaScriptCore/runtime

Timestamp:

Mar 18, 2009, 4:21:51 PM (16 years ago)

Author:

[email protected]

Message:

2009-03-18 Gustavo Noronha Silva <Gustavo Noronha Silva> and Thadeu Lima de Souza Cascardo <​[email protected]>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=24674
Crashes in !PLATFORM(MAC)'s formatLocaleDate, in very specific situations

Make sure strftime never returns 2-digits years to avoid ambiguity and
a crash.

• runtime/DatePrototype.cpp: (JSC::formatLocaleDate):

File:

• trunk/JavaScriptCore/runtime/DatePrototype.cpp (modified) (3 diffs)

trunk/JavaScriptCore/runtime/DatePrototype.cpp

@@ -28 +28 @@
 #include "DateInstance.h"
 #include <float.h>
+#include <langinfo.h>
 #include <limits.h>
 #include <locale.h>
@@ -182 +183 @@
 static JSCell* formatLocaleDate(ExecState* exec, const GregorianDateTime& gdt, LocaleDateTimeFormat format)
 {
-    static const char* const formatStrings[] = { "%#c", "%#x", "%X" };
+    static const nl_item formats[] = { D_T_FMT, D_FMT, T_FMT };
  
     // Offset year if needed
@@ -191 +192 @@
         localTM.tm_year = equivalentYearForDST(year) - 1900;
  
+    // We do not allow strftime to generate dates with 2-digits years,
+    // both to avoid ambiguity, and a crash in strncpy, for years that
+    // need offset.
+    char* formatString = strdup(nl_langinfo(formats[format]));
+    char* yPos = strchr(formatString, 'y');
+    if (yPos)
+        *yPos = 'Y';
+
     // Do the formatting
     const int bufsize = 128;
     char timebuffer[bufsize];
-    size_t ret = strftime(timebuffer, bufsize, formatStrings[format], &localTM);
+    size_t ret = strftime(timebuffer, bufsize, formatString, &localTM);
+
+    free(formatString);
  
     if (ret == 0)