Changeset 4191 in webkit for trunk/JavaScriptCore/kjs

Timestamp:

Apr 25, 2003, 3:47:05 PM (22 years ago)

Author:

darin

Message:

Reviewed by Maciej.

• a couple improvements that give a 6.6% speedup on iBench JavaScript

• kjs/nodes.cpp: (ResolveNode::evaluate): Don't use evaluateReference.

• kjs/object.cpp: (ObjectImp::get): Do the prototype work with the ValueImp, not a wrapper. Contributes a tiny bit to the speedup, but cleaner anyway. (ObjectImp::hasProperty): Same thing here.

Location:

trunk/JavaScriptCore/kjs

Files:

• nodes.cpp (modified) (1 diff)
• object.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/nodes.cpp

@@ -222 +222 @@
 Value ResolveNode::evaluate(ExecState *exec)
 {
-  return evaluateReference(exec).getValue(exec);
+  // This is the same as calling evaluateReference(exec).getValue(exec),
+  // only considerably faster.
+  
+  ScopeChain chain = exec->context().imp()->scopeChain();
+
+  while (!chain.isEmpty()) {
+    ObjectImp *o = chain.top();
+    Value result = o->get(exec, ident);
+    if (result.type() != UndefinedType)
+      return result;
+    chain.pop();
+  }
+
+  return Reference(Null(), ident).getValue(exec);
 }
 

trunk/JavaScriptCore/kjs/object.cpp

@@ -140 +140 @@
 {
   ValueImp *imp = getDirect(propertyName);
-  if ( imp )
+  if (imp)
     return Value(imp);
-
-  Object proto = Object::dynamicCast(prototype());
-  if (proto.isNull())
-    return Undefined();
 
   // non-standard netscape extension
   if (propertyName == specialPrototypePropertyName)
-    return proto;
-
-  return proto.get(exec,propertyName);
+    return Value(_proto);
+
+  if (_proto->dispatchType() != ObjectType)
+    return Undefined();
+
+  return static_cast<ObjectImp *>(_proto)->get(exec, propertyName);
 }
 
@@ -224 +223 @@
     return true;
 
+  if (_proto->dispatchType() != ObjectType)
+    return false;
+
   // Look in the prototype
-  Object proto = Object::dynamicCast(prototype());
-  return !proto.isNull() && proto.hasProperty(exec,propertyName);
+  return static_cast<ObjectImp *>(_proto)->hasProperty(exec, propertyName);
 }