Changeset 43100 in webkit for trunk/JavaScriptCore

Timestamp:

Apr 30, 2009, 2:51:57 PM (16 years ago)

Author:

[email protected]

Message:

2009-04-30 Gavin Barraclough <​[email protected]>

Reviewed by Oliver "Abandon Ship!" Hunt.

Fix a leak in Yarr.

All Disjunctions should be recorded in RegexPattern::m_disjunctions,
so that they can be freed at the end of compilation - copyDisjunction
is failing to do so.

• yarr/RegexCompiler.cpp: (JSC::Yarr::RegexPatternConstructor::copyDisjunction):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• yarr/RegexCompiler.cpp (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2009-04-30  Gavin Barraclough  <[email protected]>
+
+        Reviewed by Oliver "Abandon Ship!" Hunt.
+
+        Fix a leak in Yarr.
+
+        All Disjunctions should be recorded in RegexPattern::m_disjunctions,
+        so that they can be freed at the end of compilation - copyDisjunction
+        is failing to do so.
+
+        * yarr/RegexCompiler.cpp:
+        (JSC::Yarr::RegexPatternConstructor::copyDisjunction):
+
 2009-04-30  Oliver Hunt  <[email protected]>
 

trunk/JavaScriptCore/yarr/RegexCompiler.cpp

@@ -495 +495 @@
         }
 
+        m_pattern.m_disjunctions.append(newDisjunction);
         return newDisjunction;
     }