Changeset 43121 in webkit for trunk/JavaScriptCore/interpreter

Timestamp:

May 1, 2009, 2:20:11 PM (16 years ago)

Author:

[email protected]

Message:

2009-05-01 Geoffrey Garen <​[email protected]>

Reviewed by Sam "That doesn't look like what I thought it looks like" Weinig.

Beefed up the JSValuePtr class and removed some non-JSValuePtr dependencies
on JSImmediate, in prepapration for making JSImmediate an implementation
detail of JSValuePtr.

SunSpider reports no change.

• interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
• jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
• jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_mod):
• runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt): Updated for interface changes.

• runtime/JSImmediate.h: (JSC::JSValuePtr::JSValuePtr):
• runtime/JSValue.h: (JSC::JSValuePtr::): (JSC::jsImpossibleValue): (JSC::jsNull): (JSC::jsUndefined): (JSC::jsBoolean): (JSC::JSValuePtr::encode): (JSC::JSValuePtr::decode): (JSC::JSValuePtr::JSValuePtr): (JSC::JSValuePtr::operator bool): (JSC::JSValuePtr::operator==): (JSC::JSValuePtr::operator!=): (JSC::JSValuePtr::isUndefined): (JSC::JSValuePtr::isNull): Changed jsImpossibleValue(), jsNull(), jsUndefined(), and jsBoolean() to operate in terms of JSValuePtr instead of JSImmediate.

• wtf/StdLibExtras.h: (WTF::bitwise_cast): Fixed up for clarity.

File:

• trunk/JavaScriptCore/interpreter/Interpreter.cpp (modified) (1 diff)

trunk/JavaScriptCore/interpreter/Interpreter.cpp

@@ -1568 +1568 @@
         JSValuePtr divisorValue = callFrame[divisor].jsValue();
 
-        if (JSValuePtr::areBothInt32Fast(dividendValue, divisorValue) && divisorValue != js0()) {
+        if (JSValuePtr::areBothInt32Fast(dividendValue, divisorValue) && divisorValue != jsNumber(callFrame, 0)) {
             // We expect the result of the modulus of a number that was representable as an int32 to also be representable
             // as an int32.