Changeset 43153 in webkit for trunk/JavaScriptCore/interpreter

Timestamp:

May 2, 2009, 6:58:45 PM (16 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2009-05-02 Geoffrey Garen <​[email protected]>

Reviewed by Sam Weinig.

Simplified null-ish JSValues.

Replaced calls to noValue() with calls to JSValue() (which is what
noValue() returned). Removed noValue().

Replaced almost all uses of jsImpossibleValue() with uses of JSValue().
Its one remaining use is for construction of hash table deleted values.
For that specific task, I made a new, private constructor with a special
tag. Removed jsImpossibleValue().

Removed "JSValue()" initialiazers, since default construction happens...
by default.

• API/JSCallbackObjectFunctions.h: (JSC::::call):
• bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitLoad):
• bytecompiler/BytecodeGenerator.h:
• debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate):
• debugger/DebuggerCallFrame.h: (JSC::DebuggerCallFrame::DebuggerCallFrame):
• interpreter/CallFrame.h: (JSC::ExecState::clearException):
• interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveLastCaller):
• interpreter/Register.h: (JSC::Register::Register):
• jit/JITCall.cpp: (JSC::JIT::unlinkCall): (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCall):
• jit/JITStubs.cpp: (JSC::JITStubs::cti_op_call_eval): (JSC::JITStubs::cti_vm_throw):
• profiler/Profiler.cpp: (JSC::Profiler::willExecute): (JSC::Profiler::didExecute):
• runtime/ArrayPrototype.cpp: (JSC::getProperty):
• runtime/Completion.cpp: (JSC::evaluate):
• runtime/Completion.h: (JSC::Completion::Completion):
• runtime/GetterSetter.cpp: (JSC::GetterSetter::getPrimitiveNumber):
• runtime/JSArray.cpp: (JSC::JSArray::putSlowCase): (JSC::JSArray::deleteProperty): (JSC::JSArray::increaseVectorLength): (JSC::JSArray::setLength): (JSC::JSArray::pop): (JSC::JSArray::sort): (JSC::JSArray::compactForSorting):
• runtime/JSCell.cpp: (JSC::JSCell::getJSNumber):
• runtime/JSCell.h: (JSC::JSValue::getJSNumber):
• runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
• runtime/JSImmediate.h: (JSC::JSImmediate::fromNumberOutsideIntegerRange): (JSC::JSImmediate::from):
• runtime/JSNumberCell.cpp: (JSC::jsNumberCell):
• runtime/JSObject.cpp: (JSC::callDefaultValueFunction):
• runtime/JSObject.h: (JSC::JSObject::getDirect):
• runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::toPrimitive):
• runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::next):
• runtime/JSValue.h: (JSC::JSValue::): (JSC::JSValueHashTraits::constructDeletedValue): (JSC::JSValueHashTraits::isDeletedValue): (JSC::JSValue::JSValue):
• runtime/JSWrapperObject.h: (JSC::JSWrapperObject::JSWrapperObject):
• runtime/Operations.h: (JSC::resolveBase):
• runtime/PropertySlot.h: (JSC::PropertySlot::clearBase): (JSC::PropertySlot::clearValue):

WebCore:

2009-05-02 Geoffrey Garen <​[email protected]>

Reviewed by Sam Weinig.

Simplified null-ish JSValues.

Replaced calls to noValue() with calls to JSValue() (which is what
noValue() returned). Removed noValue().

Removed "JSValue()" initialiazers, since default construction happens...
by default.

• bindings/js/JSDOMBinding.cpp: (WebCore::setDOMException):
• bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog):
• bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
• bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::evaluate):
• bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
• bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
• bindings/js/ScriptValue.h: (WebCore::ScriptValue::ScriptValue): (WebCore::ScriptValue::hasNoValue):
• bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
• bridge/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
• bridge/jni/jni_runtime.cpp: (JavaField::dispatchValueFromInstance): (JavaField::dispatchSetValueToInstance):
• bridge/runtime.h: (JSC::Bindings::Instance::invokeConstruct):

WebKit/mac:

2009-05-02 Geoffrey Garen <​[email protected]>

Reviewed by Sam Weinig.

Simplified null-ish JSValues.

Replaced calls to noValue() with calls to JSValue() (which is what
noValue() returned). Removed noValue().

Removed "JSValue()" initialiazers, since default construction happens...
by default.

• WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame evaluateWebScript:]):

Location:

trunk/JavaScriptCore/interpreter

Files:

• CallFrame.h (modified) (1 diff)
• Interpreter.cpp (modified) (6 diffs)
• Register.h (modified) (1 diff)

trunk/JavaScriptCore/interpreter/CallFrame.h

@@ -75 +75 @@
 
         void setException(JSValue exception) { globalData().exception = exception; }
-        void clearException() { globalData().exception = noValue(); }
+        void clearException() { globalData().exception = JSValue(); }
         JSValue exception() const { return globalData().exception; }
         JSValue* exceptionSlot() { return &globalData().exception; }

trunk/JavaScriptCore/interpreter/Interpreter.cpp

@@ -1095 +1095 @@
             ASSERT(m_opcodeIDTable.size() == numOpcodeIDs);
         #endif // HAVE(COMPUTED_GOTO)
-        return noValue();
+        return JSValue();
     }
 
@@ -1104 +1104 @@
 
     JSGlobalData* globalData = &callFrame->globalData();
-    JSValue exceptionValue = noValue();
+    JSValue exceptionValue;
     HandlerInfo* handler = 0;
 
@@ -1113 +1113 @@
 #define CHECK_FOR_EXCEPTION() \
     do { \
-        if (UNLIKELY(globalData->exception != noValue())) { \
+        if (UNLIKELY(globalData->exception != JSValue())) { \
             exceptionValue = globalData->exception; \
             goto vm_throw; \
@@ -3568 +3568 @@
         int ex = (++vPC)->u.operand;
         callFrame[ex] = exceptionValue;
-        exceptionValue = noValue();
+        exceptionValue = JSValue();
 
         ++vPC;
@@ -3757 +3757 @@
     }
     vm_throw: {
-        globalData->exception = noValue();
+        globalData->exception = JSValue();
         if (!tickCount) {
             // The exceptionValue is a lie! (GCC produces bad code for reasons I 
@@ -3825 +3825 @@
 void Interpreter::retrieveLastCaller(CallFrame* callFrame, int& lineNumber, intptr_t& sourceID, UString& sourceURL, JSValue& function) const
 {
-    function = noValue();
+    function = JSValue();
     lineNumber = -1;
     sourceURL = UString();

trunk/JavaScriptCore/interpreter/Register.h

@@ -106 +106 @@
     {
 #ifndef NDEBUG
-        u.value = JSValue::encode(noValue());
+        u.value = JSValue::encode(JSValue());
 #endif
     }