Changeset 43397 in webkit for trunk/JavaScriptCore/bytecode

Timestamp:

May 8, 2009, 4:30:32 AM (16 years ago)

Author:

[email protected]

Message:

2009-05-08 Gavin Barraclough <​[email protected]>

Rubber stamped by Oliver Hunt.

Removing an empty constructor and an uncalled, empty function seems to be a
pretty solid 1% regeression on my machine, so I'm going to put them back.
Um. Yeah, this this pretty pointles and makes no sense at all. I officially
lose the will to live in 3... 2...

• bytecode/SamplingTool.cpp: (JSC::SamplingTool::notifyOfScope):
• bytecode/SamplingTool.h: (JSC::SamplingTool::~SamplingTool):

Location:

trunk/JavaScriptCore/bytecode

Files:

• SamplingTool.cpp (modified) (1 diff)
• SamplingTool.h (modified) (1 diff)

trunk/JavaScriptCore/bytecode/SamplingTool.cpp

@@ -210 +210 @@
 }
 
+void SamplingTool::notifyOfScope(ScopeNode* scope)
+{
 #if ENABLE(CODEBLOCK_SAMPLING)
-void SamplingTool::notifyOfScope(ScopeNode* scope)
-{
     MutexLocker locker(m_scopeSampleMapMutex);
     m_scopeSampleMap->set(scope, new ScopeSampleRecord(scope));
-}
-#endif
+#else
+    UNUSED_PARAM(scope);
+#endif
+}
 
 void SamplingTool::setup()

trunk/JavaScriptCore/bytecode/SamplingTool.h

@@ -200 +200 @@
         }
 
+        ~SamplingTool()
+        {
 #if ENABLE(CODEBLOCK_SAMPLING)
-        ~SamplingTool()
-        {
             deleteAllValues(*m_scopeSampleMap);
-        }
-
-        void notifyOfScope(ScopeNode* scope);
-#endif
+#endif
+        }
 
         void setup();
         void dump(ExecState*);
+
+        void notifyOfScope(ScopeNode* scope);
 
         void sample(CodeBlock* codeBlock, Instruction* vPC)