Changeset 43441 in webkit for trunk/JavaScriptCore

Timestamp:

May 9, 2009, 3:05:34 PM (16 years ago)

Author:

[email protected]

Message:

2009-05-09 Geoffrey Garen <​[email protected]>

Reviewed by Cameron Zwarich.

Removed the last non-call-related manually managed JIT stub call.

• jit/JITArithmetic.cpp: (JSC::JIT::compileFastArithSlow_op_rshift): Fully use the JITStubCall abstraction, instead of emitPutJITStubArg.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• jit/JITArithmetic.cpp (modified) (2 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2009-05-09  Geoffrey Garen  <[email protected]>
+
+        Reviewed by Cameron Zwarich.
+        
+        Removed the last non-call-related manually managed JIT stub call.
+
+        * jit/JITArithmetic.cpp:
+        (JSC::JIT::compileFastArithSlow_op_rshift): Fully use the JITStubCall
+        abstraction, instead of emitPutJITStubArg.
+
 2009-05-09  Sebastian Andrzej Siewior  <[email protected]>
 

trunk/JavaScriptCore/jit/JITArithmetic.cpp

@@ -189 +189 @@
     emitPutVirtualRegister(result);
 }
+
 void JIT::compileFastArithSlow_op_rshift(unsigned result, unsigned op1, unsigned op2, Vector<SlowCaseEntry>::iterator& iter)
 {
     linkSlowCase(iter);
-    if (isOperandConstantImmediateInt(op2))
-        emitPutJITStubArgFromVirtualRegister(op2, 2, regT2);
-    else {
+    JITStubCall stubCall(this, JITStubs::cti_op_rshift);
+
+    if (isOperandConstantImmediateInt(op2)) {
+        stubCall.addArgument(regT0);
+        stubCall.addArgument(op2, regT2);
+    } else {
         if (isSSE2Present()) {
 #if USE(ALTERNATE_JSIMMEDIATE)
@@ -207 +211 @@
             // we have not munged the operand.  It may have already been shifted
             // correctly, but it still will not have been tagged.
-            emitGetVirtualRegister(op1, regT0);
+            stubCall.addArgument(op1, regT0);
+            stubCall.addArgument(regT2);
         } else {
             linkSlowCase(iter);
             linkSlowCase(iter);
-        }
-        emitPutJITStubArg(regT2, 2);
-    }
-
-    JITStubCall stubCall(this, JITStubs::cti_op_rshift);
-    stubCall.addArgument(regT0);
+            stubCall.addArgument(regT0);
+            stubCall.addArgument(regT2);
+        }
+    }
+
     stubCall.call(result);
 }