Changeset 43849 in webkit for trunk/JavaScriptCore/jit

Timestamp:

May 18, 2009, 8:40:09 PM (16 years ago)

Author:

[email protected]

Message:

2009-05-18 Maciej Stachowiak <​[email protected]>

Reviewed by Geoff Garen.

• Improve code generation for access to prototype properties

~0.4% speedup on SunSpider.

Based on a suggestion from Geoff Garen.

• jit/JIT.h:
• jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetDirectOffset): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):

Location:

trunk/JavaScriptCore/jit

Files:

• JIT.h (modified) (1 diff)
• JITPropertyAccess.cpp (modified) (5 diffs)

trunk/JavaScriptCore/jit/JIT.h

@@ -389 +389 @@
 
         void compileGetDirectOffset(RegisterID base, RegisterID result, Structure* structure, size_t cachedOffset);
-        void compileGetDirectOffset(JSObject* base, RegisterID temp, RegisterID result, size_t cachedOffset);
+        void compileGetDirectOffset(JSObject* base, RegisterID result, size_t cachedOffset);
         void compilePutDirectOffset(RegisterID base, RegisterID value, Structure* structure, size_t cachedOffset);
 

trunk/JavaScriptCore/jit/JITPropertyAccess.cpp

@@ -324 +324 @@
 }
 
-void JIT::compileGetDirectOffset(JSObject* base, RegisterID temp, RegisterID result, size_t cachedOffset)
+void JIT::compileGetDirectOffset(JSObject* base, RegisterID result, size_t cachedOffset)
 {
     if (base->isUsingInlineStorage())
         loadPtr(static_cast<void*>(&base->m_inlineStorage[cachedOffset]), result);
-    else {
-        PropertyStorage* protoPropertyStorage = &base->m_externalStorage;
-        loadPtr(static_cast<void*>(protoPropertyStorage), temp);
-        loadPtr(Address(temp, cachedOffset * sizeof(JSValue)), result);
-    } 
+    else
+        loadPtr(static_cast<void*>(&base->m_externalStorage[cachedOffset]), result);
 }
 
@@ -529 +526 @@
 
     // Checks out okay! - getDirectOffset
-    compileGetDirectOffset(protoObject, regT1, regT0, cachedOffset);
+    compileGetDirectOffset(protoObject, regT0, cachedOffset);
 
     Jump success = jump();
@@ -602 +599 @@
 
     // Checks out okay! - getDirectOffset
-    compileGetDirectOffset(protoObject, regT1, regT0, cachedOffset);
+    compileGetDirectOffset(protoObject, regT0, cachedOffset);
 
     Jump success = jump();
@@ -656 +653 @@
     ASSERT(protoObject);
 
-    compileGetDirectOffset(protoObject, regT1, regT0, cachedOffset);
+    compileGetDirectOffset(protoObject, regT0, cachedOffset);
     Jump success = jump();
 
@@ -712 +709 @@
     ASSERT(protoObject);
 
-    compileGetDirectOffset(protoObject, regT1, regT0, cachedOffset);
+    compileGetDirectOffset(protoObject, regT0, cachedOffset);
     Jump success = jump();