Changeset 43976 in webkit for trunk/JavaScriptCore/bytecompiler

Timestamp:

May 21, 2009, 12:57:26 PM (16 years ago)

Author:

[email protected]

Message:

Fix <​https://bugs.webkit.org/show_bug.cgi?id=25917> / <rdar://problem/6910066>.
Bug 25917: REGRESSION (r43559?): Javascript debugger crashes when pausing page

Reviewed by Oliver Hunt.

The debugger currently retrieves the arguments object from an activation rather than pulling
it from a call frame. This is unreliable to due to the recent optimization to lazily create
the arguments object. In the long-term it should stop doing that (<rdar://problem/6911886>),
but for now we force eager creation of the arguments object when debugging.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

File:

• trunk/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp (modified) (1 diff)

trunk/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp

@@ -333 +333 @@
         emitOpcode(op_enter);
 
-     if (usesArguments)
+     if (usesArguments) {
         emitOpcode(op_init_arguments);
+
+        // The debugger currently retrieves the arguments object from an activation rather than pulling
+        // it from a call frame.  In the long-term it should stop doing that (<rdar://problem/6911886>),
+        // but for now we force eager creation of the arguments object when debugging.
+        if (m_shouldEmitDebugHooks)
+            emitOpcode(op_create_arguments);
+    }
 
     const DeclarationStacks::FunctionStack& functionStack = functionBody->functionStack();