Changeset 44169 in webkit for trunk/JavaScriptCore

Timestamp:

May 26, 2009, 5:33:13 PM (16 years ago)

Author:

[email protected]

Message:

2009-05-26 Gavin Barraclough <​[email protected]>

Reviewed by Oliver "pieces of eight" Hunt.

When reseting RegexPattern class, should fully reset the class, not just bits of it.
In particular, we delete the cached character classes (for wordchars, etc), but do
not reset the set of pointers to the cached classes. In the case of a repeated parse
due to an illegal back-reference we will continue to use the deleted character class.

• yarr/RegexPattern.h: (JSC::Yarr::RegexPattern::reset):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• yarr/RegexPattern.h (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2009-05-26  Gavin Barraclough  <[email protected]>
+
+        Reviewed by Oliver "pieces of eight" Hunt.
+
+        When reseting RegexPattern class, should fully reset the class, not just bits of it.
+        In particular, we delete the cached character classes (for wordchars, etc), but do
+        not reset the set of pointers to the cached classes.  In the case of a repeated parse
+        due to an illegal back-reference we will continue to use the deleted character class.
+
+        * yarr/RegexPattern.h:
+        (JSC::Yarr::RegexPattern::reset):
+
 2009-05-26  Brent Fulgham  <[email protected]>
 

trunk/JavaScriptCore/yarr/RegexPattern.h

@@ -264 +264 @@
         m_maxBackReference = 0;
 
+        newlineCached = 0;
+        digitsCached = 0;
+        spacesCached = 0;
+        wordcharCached = 0;
+        nondigitsCached = 0;
+        nonspacesCached = 0;
+        nonwordcharCached = 0;
+
         deleteAllValues(m_disjunctions);
         m_disjunctions.clear();