Changeset 44457 in webkit for trunk/JavaScriptCore/assembler

Timestamp:

Jun 5, 2009, 2:19:23 AM (16 years ago)

Author:

[email protected]

Message:

2009-06-05 Gavin Barraclough <​[email protected]>

Reviewed by Oliver Hunt.

3 tiny cleanups:

• assembler/MacroAssemblerX86.h:
• assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::storePtrWithPatch):

store*() methods should take an ImplicitAddress, rather than an Address.

• assembler/X86Assembler.h:

Make patchPointer private.

• jit/JITOpcodes.cpp: (JSC::JIT::emit_op_ret):

Remove empty line at end of function.

Location:

trunk/JavaScriptCore/assembler

Files:

• MacroAssemblerX86.h (modified) (1 diff)
• MacroAssemblerX86_64.h (modified) (1 diff)
• X86Assembler.h (modified) (2 diffs)

trunk/JavaScriptCore/assembler/MacroAssemblerX86.h

@@ -146 +146 @@
     }
 
-    DataLabelPtr storePtrWithPatch(Address address)
+    DataLabelPtr storePtrWithPatch(ImplicitAddress address)
     {
         m_assembler.movl_i32m(0, address.offset, address.base);

trunk/JavaScriptCore/assembler/MacroAssemblerX86_64.h

@@ -430 +430 @@
     }
 
-    DataLabelPtr storePtrWithPatch(Address address)
+    DataLabelPtr storePtrWithPatch(ImplicitAddress address)
     {
         DataLabelPtr label = moveWithPatch(ImmPtr(0), scratchRegister);

trunk/JavaScriptCore/assembler/X86Assembler.h

@@ -1384 +1384 @@
     }
 
-    static void patchPointer(void* where, void* value)
-    {
-        reinterpret_cast<void**>(where)[-1] = value;
-    }
-
 #if PLATFORM(X86_64)
     static void patchPointerForCall(void* where, void* value)
@@ -1474 +1469 @@
 
 private:
+
+    static void patchPointer(void* where, void* value)
+    {
+        reinterpret_cast<void**>(where)[-1] = value;
+    }
 
     static void patchInt32(void* where, int32_t value)