Changeset 44713 in webkit for trunk/JavaScriptCore/assembler

Timestamp:

Jun 15, 2009, 11:52:49 PM (16 years ago)

Author:

[email protected]

Message:

2009-06-15 Gavin Barraclough <​[email protected]>

Rubber Stamped by Sam Weinig.

Rename PatchBuffer to LinkBuffer. Previously our terminology has been a little
mixed up, but we have decided to fix on refering to the process that takes place
at the end of code generation as 'linking', and on any modifications that take
place later (and once the code has potentially already been executed) as 'patching'.

However, the term 'PatchBuffer' is already in use, and needs to be repurposed.

To try to minimize confusion, we're going to switch the terminology over in stages,
so for now we'll refer to later modifications as 'repatching'. This means that the
new 'PatchBuffer' has been introduced with the name 'RepatchBuffer' instead.

This patch renames the old 'PatchBuffer' to 'LinkBuffer'. We'll leave ToT in this
state for a week or so to try to avoid to much overlap of the meaning of the term
'PatchBuffer', then will come back and rename 'RepatchBuffer'.

• assembler/ARMv7Assembler.h:
• assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::LinkBuffer::LinkBuffer): (JSC::AbstractMacroAssembler::LinkBuffer::~LinkBuffer):
• jit/JIT.cpp: (JSC::JIT::privateCompile):
• jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
• yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::compile):

Location:

trunk/JavaScriptCore/assembler

Files:

• ARMv7Assembler.h (modified) (1 diff)
• AbstractMacroAssembler.h (modified) (11 diffs)

trunk/JavaScriptCore/assembler/ARMv7Assembler.h

@@ -1521 +1521 @@
     }
 
-    // bah, this mathod should really be static, since it is used by the PatchBuffer.
+    // bah, this mathod should really be static, since it is used by the LinkBuffer.
     // return a bool saying whether the link was successful?
     static void linkCall(void* code, JmpSrc from, void* to)

trunk/JavaScriptCore/assembler/AbstractMacroAssembler.h

@@ -50 +50 @@
 
     class Jump;
-    class PatchBuffer;
+    class LinkBuffer;
     class RepatchBuffer;
 
@@ -222 +222 @@
         friend class Jump;
         friend class MacroAssemblerCodeRef;
-        friend class PatchBuffer;
+        friend class LinkBuffer;
 
     public:
@@ -247 +247 @@
         template<class TemplateAssemblerType>
         friend class AbstractMacroAssembler;
-        friend class PatchBuffer;
+        friend class LinkBuffer;
     public:
         DataLabelPtr()
@@ -269 +269 @@
         template<class TemplateAssemblerType>
         friend class AbstractMacroAssembler;
-        friend class PatchBuffer;
+        friend class LinkBuffer;
     public:
         DataLabel32()
@@ -293 +293 @@
         template<class TemplateAssemblerType>
         friend class AbstractMacroAssembler;
-        friend class PatchBuffer;
+        friend class LinkBuffer;
     public:
         enum Flags {
@@ -338 +338 @@
         friend class AbstractMacroAssembler;
         friend class Call;
-        friend class PatchBuffer;
+        friend class LinkBuffer;
     public:
         Jump()
@@ -368 +368 @@
     // All jumps in the set will be linked to the same destination.
     class JumpList {
-        friend class PatchBuffer;
+        friend class LinkBuffer;
 
     public:
@@ -407 +407 @@
 
 
-    // Section 3: PatchBuffer - utility to finalize code generation.
+    // Section 3: LinkBuffer - utility to finalize code generation.
 
     static CodePtr trampolineAt(CodeRef ref, Label label)
@@ -414 +414 @@
     }
 
-    // PatchBuffer:
+    // LinkBuffer:
     //
     // This class assists in linking code generated by the macro assembler, once code generation
@@ -431 +431 @@
     // address of calls, as opposed to a point that can be used to later relink a Jump -
     // possibly wrap the later up in an object that can do just that).
-    class PatchBuffer : public Noncopyable {
+    class LinkBuffer : public Noncopyable {
     public:
         // Note: Initialization sequence is significant, since executablePool is a PassRefPtr.
         //       First, executablePool is copied into m_executablePool, then the initialization of
         //       m_code uses m_executablePool, *not* executablePool, since this is no longer valid.
-        PatchBuffer(AbstractMacroAssembler<AssemblerType>* masm, PassRefPtr<ExecutablePool> executablePool)
+        LinkBuffer(AbstractMacroAssembler<AssemblerType>* masm, PassRefPtr<ExecutablePool> executablePool)
             : m_executablePool(executablePool)
             , m_code(masm->m_assembler.executableCopy(m_executablePool.get()))
@@ -446 +446 @@
         }
 
-        ~PatchBuffer()
+        ~LinkBuffer()
         {
             ASSERT(m_completed);