Changeset 45733 in webkit for trunk/JavaScriptCore/debugger

Timestamp:

Jul 10, 2009, 4:00:13 PM (16 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2009-07-10 Kevin McCullough <​[email protected]>

Reviewed by Geoffrey Garen.

• debugger/Debugger.h: Made this function virtual for use in WebCore's WebInspector.

WebCore:

2009-07-10 Kevin McCullough <​[email protected]>

Reviewed by Geoffrey Garen.

• inspector/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::dynamicGlobalObject):
• inspector/JavaScriptCallFrame.h: New helper method, used below.

• inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::detach): In the special case where we detach from a window currently executing JavaScript, manually tear down our representation of the JavaScript call stack, since we won't get any more callbacks from JavaScriptCore to automatically tear it down. It's too bad that WebCore is responsible for this kind of tracking -- in the future, it would be nice if more of the breakpoint handling was inside of JavaScriptCore.

File:

• trunk/JavaScriptCore/debugger/Debugger.h (modified) (1 diff)

trunk/JavaScriptCore/debugger/Debugger.h

@@ -39 +39 @@
 
         void attach(JSGlobalObject*);
-        void detach(JSGlobalObject*);
+        virtual void detach(JSGlobalObject*);
 
         virtual void sourceParsed(ExecState*, const SourceCode&, int errorLine, const UString& errorMsg) = 0;