Changeset 45903 in webkit for trunk/JavaScriptCore

Timestamp:

Jul 15, 2009, 2:59:23 AM (16 years ago)

Author:

[email protected]

Message:

REGRESSION(43559): fast/js/kde/arguments-scope.html fails with interpreter
​https://bugs.webkit.org/show_bug.cgi?id=27259

Reviewed by Simon Hausmann

The interpreter was incorrectly basing its need to create the arguments object
based on the presence of the callframe's argument reference rather than the local
arguments reference. Based on this it then overrode the local variable reference.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• interpreter/Interpreter.cpp (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2009-07-15  Oliver Hunt  <[email protected]>
+
+        Reviewed by Simon Hausmann.
+
+        REGRESSION(43559): fast/js/kde/arguments-scope.html fails with interpreter
+        https://bugs.webkit.org/show_bug.cgi?id=27259
+
+        The interpreter was incorrectly basing its need to create the arguments object
+        based on the presence of the callframe's argument reference rather than the local
+        arguments reference.  Based on this it then overrode the local variable reference.
+
+        * interpreter/Interpreter.cpp:
+        (JSC::Interpreter::privateExecute):
+
 2009-07-14  Steve Falkenburg  <[email protected]>
 

trunk/JavaScriptCore/interpreter/Interpreter.cpp

@@ -3403 +3403 @@
          */
         
-         if (!callFrame->optionalCalleeArguments()) {
+         if (!callFrame->r(RegisterFile::ArgumentsRegister).jsValue()) {
              Arguments* arguments = new (globalData) Arguments(callFrame);
              callFrame->setCalleeArguments(arguments);